Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executeWorkflowTrigger): add substitution for workflow input values #12111

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Dec 9, 2024

Summary

add substitution for workflow input values

video: https://www.loom.com/share/ddc36f68c85d4f70876d8d92f864deea

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2898/execute-workflow-node-add-workflow-inputs-parameter

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@igatanasov igatanasov added node/improvement New feature or request core Enhancement outside /nodes-base and /editor-ui labels Dec 9, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 9, 2024
@igatanasov igatanasov force-pushed the ado-2898-implement-values-expression-substitution branch from c28c7b8 to 8104a92 Compare December 9, 2024 21:56
@igatanasov igatanasov changed the title add substitution for workflow input values feat: (executeWorkflowTrigger) add substitution for workflow input values Dec 9, 2024
@igatanasov igatanasov changed the title feat: (executeWorkflowTrigger) add substitution for workflow input values feat(executeWorkflowTrigger): add substitution for workflow input values Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left some comment on the potential improvements.

@igatanasov igatanasov merged commit 0cea411 into feature-sub-workflow-inputs Dec 10, 2024
17 checks passed
@igatanasov igatanasov deleted the ado-2898-implement-values-expression-substitution branch December 10, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants