-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(executeWorkflowTrigger): add substitution for workflow input values #12111
Merged
igatanasov
merged 5 commits into
feature-sub-workflow-inputs
from
ado-2898-implement-values-expression-substitution
Dec 10, 2024
Merged
feat(executeWorkflowTrigger): add substitution for workflow input values #12111
igatanasov
merged 5 commits into
feature-sub-workflow-inputs
from
ado-2898-implement-values-expression-substitution
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igatanasov
added
node/improvement
New feature or request
core
Enhancement outside /nodes-base and /editor-ui
labels
Dec 9, 2024
…nto ado-2898-implement-values-expression-substitution
igatanasov
force-pushed
the
ado-2898-implement-values-expression-substitution
branch
from
December 9, 2024 21:56
c28c7b8
to
8104a92
Compare
igatanasov
changed the title
add substitution for workflow input values
feat: (executeWorkflowTrigger) add substitution for workflow input values
Dec 9, 2024
igatanasov
changed the title
feat: (executeWorkflowTrigger) add substitution for workflow input values
feat(executeWorkflowTrigger): add substitution for workflow input values
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
MiloradFilipovic
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left some comment on the potential improvements.
packages/nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflow/ExecuteWorkflow.node.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflow/ExecuteWorkflow.node.ts
Show resolved
Hide resolved
.../nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflowTrigger/ExecuteWorkflowTrigger.node.test.ts
Show resolved
Hide resolved
igatanasov
deleted the
ado-2898-implement-values-expression-substitution
branch
December 10, 2024 11:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
node/improvement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add substitution for workflow input values
video: https://www.loom.com/share/ddc36f68c85d4f70876d8d92f864deea
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2898/execute-workflow-node-add-workflow-inputs-parameter
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)