chore(Execute Workflow Node): Update text copy for ExecuteWorkflow node and ResourceMapper #12277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieKolb
changed the title
n8n-assistant
bot
added
n8n team
CharlieKolb
commented
Dec 19, 2024
| @@ -67,22 +67,26 @@ export class ExecuteWorkflowTrigger implements INodeType { | |||
| default: 'worklfow_call', | |||
| }, | |||
| { | |||
| displayName: 'Input Source', | |||
| // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased | |||
There was a problem hiding this comment.
We should probably update this since we're committing to lower case dropdowns. 155 exceptions means it's not a good rule :D
CharlieKolb
commented
Dec 19, 2024
| @@ -17,8 +17,7 @@ export class LoadWorkflowNodeContext extends NodeExecutionContext implements IWo | |||
| this.getNodeParameter = (( | |||
| parameterName: string, | |||
| itemIndex: number, | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| fallbackValue?: any, | |||
| fallbackValue?: unknown, | |||
There was a problem hiding this comment.
oops, this is from my review, lets leave it in rather than restart CI? It's a safe change.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
MiloradFilipovic
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update text copy according to ticket and product review issues.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2972/feature-unify-naming-convention-for-sub-workflows
https://www.notion.so/n8n/Button-Copy-is-inconsistent-1595b6e0c94f80ee8394d2c2046fcb1a?pvs=4
https://www.notion.so/n8n/Change-wording-of-Input-source-and-its-options-1595b6e0c94f80a09d77c6673d52228a?pvs=4
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)