Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Switch from lodash.set to lodash to address CVE-2020-8203 (no-changelog) #12286

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(core): Switch from lodash.set to lodash to address CVE-2020-8203 (no-changelog) #12286

merged 1 commit into from
Dec 18, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 18, 2024

Summary

GitHub Advisory

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024

n8n    Run #8406

Run Properties:  status check passed Passed #8406  •  git commit 94bf70d8b6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-CVE-2020-8203-upgrade-lodash
Run status status check passed Passed #8406
Run duration 04m 43s
Commit git commit 94bf70d8b6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 481
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 7ce4e8d into master Dec 18, 2024
37 checks passed
@netroy netroy deleted the fix-CVE-2020-8203-upgrade-lodash branch December 18, 2024 19:05
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @tomi