Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Deduplicate isObjectLiteral, add docs and tests #12332

Merged
merged 4 commits into from
Dec 20, 2024
Merged

refactor(core): Deduplicate isObjectLiteral, add docs and tests #12332

merged 4 commits into from
Dec 20, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 20, 2024

Summary

Extracted out of #12310 to address some of the comments on that PR.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy requested a review from a team as a code owner December 20, 2024 14:11
ivov
ivov reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, really thorough!

packages/core/src/utils.ts Outdated Show resolved Hide resolved
packages/core/src/__tests__/utils.test.ts Show resolved Hide resolved
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 20, 2024
@netroy netroy requested a review from ivov December 20, 2024 15:09
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024

n8n    Run #8449

Run Properties:  status check passed Passed #8449  •  git commit 4a4717d0a6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review refactor-isObjectLiteral
Run status status check passed Passed #8449
Run duration 04m 40s
Commit git commit 4a4717d0a6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/core/src/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy merged commit 724e085 into master Dec 20, 2024
42 checks passed
@netroy netroy deleted the refactor-isObjectLiteral branch December 20, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netroy @ivov