Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set correct default for added Resource Mapper boolean fields #12344

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: Set correct default for added Resource Mapper boolean fields #12344

merged 1 commit into from
Dec 23, 2024

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Dec 23, 2024 •
edited
Loading

Summary

Ensure booleans are always true or false in fixed mode.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3029/bug-fix-resourcemapper-added-boolean-switch-value

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb marked this pull request as ready for review December 23, 2024 11:06
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...i/src/components/ResourceMapper/ResourceMapper.vue 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Dec 23, 2024

n8n    Run #8457

Run Properties:  status check passed Passed #8457  •  git commit d300d4f32e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review ADO-3029
Run status status check passed Passed #8457
Run duration 04m 48s
Commit git commit d300d4f32e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

@CharlieKolb CharlieKolb merged commit b4c77f2 into master Dec 23, 2024
38 checks passed
@CharlieKolb CharlieKolb deleted the ADO-3029 branch December 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlieKolb @MiloradFilipovic