Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates link to luxon documentation #12352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riascho
Copy link
Contributor

@riascho riascho commented Dec 23, 2024

Summary

Just a quick fix to update the correct link to our luxon documentation.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 23, 2024

n8n    Run #8462

Run Properties:  status check failed Failed #8462  •  git commit 7be84b7015: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Project n8n
Branch Review datetime-node-fix-luxon-docs-link
Run status status check failed Failed #8462
Run duration 38m 35s
Commit git commit 7be84b7015: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Committer Ria
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 294
View all changes introduced in this branch ↗︎

Tests for review

Failed  45-workflow-selector-parameter.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked Test Replay Screenshots Video
Failed  48-subworkflow-inputs.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  41-editors.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 49 specs in Cypress Cloud.

Flakiness  e2e/14-mapping.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Data mapping > maps expressions from json view Test Replay Screenshots Video

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants