Added a global timeout setting for all http requests except for http node #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node. The http node explicitly sets a timeout that overrides the default value. This is to prevent behaviors when users were expecting that their quests could take a very long time to execute.
krynble
force-pushed
the
timeout-for-http-requests
branch
from
aea3081 to
fc4c864
Compare
ivov
reviewed
Apr 14, 2021
|
Thanks a lot. Got merged. |
|
Got released with n8n@0.116.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http node explicitly sets a timeout that overrides the default value.
This is to prevent behaviors when users were expecting that their requests could take a very long time to execute.
This PR was created by @MedAliMarz and I just made a few minor adjustments.