🐛 Fix bug in Zendesk Trigger node with wrong conditions #1668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR for n8n so if I'm doing something wrong, please let me know. Never too late to learn!
The conditions for the Zendesk trigger node are populated in the
resultAll
andresultAny
variables.While populating these variables, the
const aux: IDataObject = {};
variable from the outer scope is used to create entries for theresultAll
andresultAny
variables.However, the
aux
variable from the outer scope is pushed to theresultAll
andresultAny
variables by reference. Therefore, at the second index in the loop, this for exampleaux.field = conditionAll.field;
will also update the value of the previously pushed item.The result is
resultAll
andresultAny
variable where the entry's are all the same.Fixed by moving the
aux
variable inside the loop scope.