Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add option to use Jira field display names #2408

Merged
merged 7 commits into from
Mar 27, 2022
Merged

✨ Add option to use Jira field display names #2408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0751ba8
✨ Add option to use Jira field display names
pemontto Dec 16, 2021
115d082
🚸 Make mapped fields more deterministic
pemontto Feb 6, 2022
0d006b3
♻️ Refactor Jira user loadOptions
pemontto Feb 6, 2022
55d1340
Merge branch 'master' of github.com:n8n-io/n8n into jira-friendly-fields
Joffcom Mar 17, 2022
6104ea6
Moved and renamed the option as well as only returning the fields to
Joffcom Mar 23, 2022
87014b5
Tweaked Friendly Fields to make it "Simplify Output" following simila…
Joffcom Mar 23, 2022
64d43e2
:zap: Improvements
RicardoE105 Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions packages/nodes-base/nodes/Jira/IssueDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,24 @@ export const issueFields: INodeProperties[] = [
default: '',
description: 'Issue Key',
},
{
displayName: 'Simplify Output',
name: 'simplifyOutput',
type: 'boolean',
required: false,
displayOptions: {
show: {
resource: [
'issue',
],
operation: [
'get',
],
},
},
default: false,
description: `Return the display value of fields instead of their ID`,
},
{
displayName: 'Additional Fields',
name: 'additionalFields',
Expand Down Expand Up @@ -577,13 +595,6 @@ export const issueFields: INodeProperties[] = [
default: false,
description: `Indicates whether fields in fields are referenced by keys rather than IDs. This parameter is useful where fields have been added by a connect app and a field's key may differ from its ID.`,
},
{
displayName: 'Friendly Field Names',
name: 'resolveCustomFields',
type: 'boolean',
default: false,
description: `Return the display value of fields instead of their ID`,
},
{
displayName: 'Properties',
name: 'properties',
Expand Down
7 changes: 4 additions & 3 deletions packages/nodes-base/nodes/Jira/Jira.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ export class Jira implements INodeType {
if (operation === 'get') {
for (let i = 0; i < length; i++) {
const issueKey = this.getNodeParameter('issueKey', i) as string;
const simplifyOutput = this.getNodeParameter('simplifyOutput', i) as boolean;
const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
if (additionalFields.fields) {
qs.fields = additionalFields.fields as string;
Expand All @@ -636,7 +637,7 @@ export class Jira implements INodeType {
if (additionalFields.expand) {
qs.expand = additionalFields.expand as string;
}
if (additionalFields.resolveCustomFields) {
if (simplifyOutput) {
qs.expand = `${qs.expand || ''},names`;
}
if (additionalFields.properties) {
Expand All @@ -647,7 +648,7 @@ export class Jira implements INodeType {
}
responseData = await jiraSoftwareCloudApiRequest.call(this, `/api/2/issue/${issueKey}`, 'GET', {}, qs);

if (additionalFields.resolveCustomFields) {
if (simplifyOutput) {
const mappedFields: IDataObject = {};
// Sort custom fields last so we map them last
const customField = /^customfield_\d+$/;
Expand Down Expand Up @@ -678,7 +679,7 @@ export class Jira implements INodeType {
}
responseData.fields = mappedFields;
}
returnData.push(responseData);
simplifyOutput ? returnData.push(responseData.fields) : returnData.push(responseData);
RicardoE105 marked this conversation as resolved.
Show resolved Hide resolved
}
}
//https://developer.atlassian.com/cloud/jira/platform/rest/v2/#api-rest-api-2-search-post
Expand Down