-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for Asana Project Creation #2532
Conversation
{ | ||
displayName: 'Project', | ||
name: 'projectId', | ||
type: 'options', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project is type options but does not have any options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally had it as getProjects but it is not as reliable as using a string so I switched to a string option
name: 'team', | ||
type: 'options', | ||
typeOptions: { | ||
loadOptionsMethod: 'getTeams', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add load dependency. Otherwise, if the workspace is not set, this will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a load dependency and I added workspace as a general field for it with a getWorkspaces option for it
body.team = additionalFields.team; | ||
} | ||
if (additionalFields.workspace) { | ||
body.workspace = additionalFields.workspace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workspace it;s not needed to update a project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit
@awitkowski0 thanks very much for your contribution. Great to hear that you are enjoying n8n. Can you please address the comment in my review? Let me know if you have questions. |
Removed Workspace from Update Fields Renamed Update Project to Update Changed Project Type options under update to string for name Added Workspace as a requirement to update projects and as a load dependency Removed Workspace from actual updating
Committed again with a bunch of changes made to resolve your questions @RicardoE105. Hopefully everything is resolved! Sorry for taking so long between commits, a lot of stuff came up in between. |
Thanks a lot for your contribution. Sorry that it took so long. Got merged and will be released with the next version. |
Got released with |
Added New Options within the Asana Node.
Namely,
This is my first PR to this repo, I have viewed all the necessary guidelines and code of conduct, but if I am in violation of anything or need to do anything else please let me know! Thanks for creating this wonderful product.