Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for Asana Project Creation #2532

Merged
merged 3 commits into from
Feb 26, 2022
Merged

Conversation

awitkowski0
Copy link
Contributor

Added New Options within the Asana Node.

Namely,

  • Project Creation
  • Project Deletion
  • Project Updates

image

This is my first PR to this repo, I have viewed all the necessary guidelines and code of conduct, but if I am in violation of anything or need to do anything else please let me know! Thanks for creating this wonderful product.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2021

CLA assistant check
All committers have signed the CLA.

{
displayName: 'Project',
name: 'projectId',
type: 'options',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project is type options but does not have any options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally had it as getProjects but it is not as reliable as using a string so I switched to a string option

name: 'team',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getTeams',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add load dependency. Otherwise, if the workspace is not set, this will not work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a load dependency and I added workspace as a general field for it with a getWorkspaces option for it

body.team = additionalFields.team;
}
if (additionalFields.workspace) {
body.workspace = additionalFields.workspace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace it;s not needed to update a project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

@RicardoE105
Copy link
Contributor

@awitkowski0 thanks very much for your contribution. Great to hear that you are enjoying n8n. Can you please address the comment in my review? Let me know if you have questions.

@ivov ivov added node/improvement New feature or request community Authored by a community member labels Dec 15, 2021
Removed Workspace from Update Fields
Renamed Update Project to Update
Changed Project Type options under update to string for name
Added Workspace as a requirement to update projects and as a load dependency
Removed Workspace from actual updating
@awitkowski0
Copy link
Contributor Author

Committed again with a bunch of changes made to resolve your questions @RicardoE105. Hopefully everything is resolved! Sorry for taking so long between commits, a lot of stuff came up in between.

@janober janober merged commit 0a92e61 into n8n-io:master Feb 26, 2022
@janober
Copy link
Member

janober commented Feb 26, 2022

Thanks a lot for your contribution. Sorry that it took so long. Got merged and will be released with the next version.

@janober janober added the Upcoming Release Will be part of the upcoming release label Feb 26, 2022
@janober
Copy link
Member

janober commented Feb 28, 2022

Got released with n8n@0.165.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants