-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for AWS temporary credentials - N8N-3209 #2587
Conversation
Bump |
@ivov Can you help guide what the next step needs to be to get this reviewed? |
Thank you very much for your contribution. This is up to @csuermann and @sirdavidoff. |
@csuermann, @sirdavidoff. Any feedback for the above PR? |
Hello. Thanks for highlighting this issue. Will take a look and try to get this into this week's release. |
@mutdmour Thank you! |
update - sorry have not been able to test this yet. @nivb06 is leading initiative to merge in community PRs and I have asked him to prioritise this. |
@BasitAli, this PR is being worked on as we speak, if there are no issues (🤞), might be released on this or the next week's update. |
Thank you for the update @nivb06 @mutdmour. |
…t using sign function from aws4 module
Hello @BasitAli I made some fixes for this PR but can not commit them because access is denied |
It's a private fork. Can you create a separate fork and share the changes with me? |
sure, please take a look here https://github.com/michael-radency/n8n/tree/aws-credentials-fix |
@michael-radency Applied the changes from your fork. |
Hello @BasitAli , thank you, pass this PR to a final stage review, hopefully it would be merged this week |
Got released with |
We recently ran into a blocker where we were fetching temporary AWS credentials for uploading a file to S3 but the AWS S3 node in n8n didn't have proper support for it.
This pull request adds the third credential parameter
sessionToken
which is then passed on to aws4.