Add /users tests for user management backend

packages/cli/src/UserManagement/UserManagementHelper.ts

@@ -2,29 +2,35 @@
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
 /* eslint-disable import/no-cycle */
 import { IsNull, Not } from 'typeorm';
-import { Db, ResponseHelper } from '..';
+import { Db, GenericHelpers, ResponseHelper } from '..';
 import config = require('../../config');
-import { User } from '../databases/entities/User';
+import { MAX_PASSWORD_LENGTH, MIN_PASSWORD_LENGTH, User } from '../databases/entities/User';
 import { PublicUser } from './Interfaces';
 
-export function isEmailSetup(): boolean {
-	const emailMode = config.get('userManagement.emails.mode') as string;
-	return !!emailMode;
+export const isEmailSetUp = Boolean(config.get('userManagement.emails.mode'));
+
+/**
+ * Return the n8n instance base URL without trailing slash.
+ */
+export function getInstanceBaseUrl(): string {
+	const baseUrl = GenericHelpers.getBaseUrl();
+	return baseUrl.endsWith('/') ? baseUrl.slice(0, baseUrl.length - 1) : baseUrl;
 }
 
 export async function isInstanceOwnerSetup(): Promise<boolean> {
 	const users = await Db.collections.User!.find({ email: Not(IsNull()) });
 	return users.length !== 0;
 }
 
+// TODO: Enforce at model level
 export function validatePassword(password?: string): string {
 	if (!password) {
 		throw new ResponseHelper.ResponseError('Password is mandatory', undefined, 400);
 	}
 
-	if (password.length < 8 || password.length > 64) {
+	if (password.length < MIN_PASSWORD_LENGTH || password.length > MAX_PASSWORD_LENGTH) {
 		throw new ResponseHelper.ResponseError(
-			'Password must be 8 to 64 characters long',
+			`Password must be ${MIN_PASSWORD_LENGTH} to ${MAX_PASSWORD_LENGTH} characters long`,
 			undefined,
 			400,
 		);

packages/cli/src/UserManagement/routes/index.ts

@@ -56,6 +56,7 @@ export function addRoutes(this: N8nApp, ignoredEndpoints: string[], restEndpoint
 			req.url.startsWith(`/${restEndpoint}/settings`) ||
 			req.url === `/${restEndpoint}/user` ||
 			req.url.startsWith(`/${restEndpoint}/resolve-signup-token`) ||
+			(req.method === 'POST' && new RegExp(`/${restEndpoint}/users/[\\w\\d-]*`).test(req.url)) ||
 			req.url.startsWith(`/${restEndpoint}/forgot-password`) ||
 			req.url.startsWith(`/${restEndpoint}/resolve-password-token`) ||
 			req.url.startsWith(`/${restEndpoint}/change-password`)

packages/cli/src/UserManagement/routes/owner.ts

@@ -11,7 +11,7 @@ import { validateEntity } from '../../GenericHelpers';
 import { OwnerRequest } from '../../requests';
 import { issueCookie } from '../auth/jwt';
 import { N8nApp } from '../Interfaces';
-import { sanitizeUser } from '../UserManagementHelper';
+import { sanitizeUser, validatePassword } from '../UserManagementHelper';
 
 export function ownerNamespace(this: N8nApp): void {
 	/**
@@ -32,13 +32,7 @@ export function ownerNamespace(this: N8nApp): void {
 				throw new ResponseHelper.ResponseError('Invalid email address', undefined, 400);
 			}
 
-			if (!password) {
-				throw new ResponseHelper.ResponseError(
-					'Password does not comply to security standards',
-					undefined,
-					400,
-				);
-			}
+			const validPassword = validatePassword(password);
 
 			if (!firstName || !lastName) {
 				throw new ResponseHelper.ResponseError(
@@ -59,7 +53,7 @@ export function ownerNamespace(this: N8nApp): void {
 				email,
 				firstName,
 				lastName,
-				password: hashSync(password, genSaltSync(10)),
+				password: hashSync(validPassword, genSaltSync(10)),
 				globalRole,
 				id: userId,
 			});