Use webhook url as fallback when editor url is not defined #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutdmour
reviewed
Mar 14, 2022
Comment on lines
59
to
61
| const n8nBaseUrl = config.get('editorBaseUrl') | ||
| ? config.get('editorBaseUrl') | ||
| : getWebhookBaseUrl(); |
There was a problem hiding this comment.
nitpick
Suggested change
| const n8nBaseUrl = config.get('editorBaseUrl') | |
| ? config.get('editorBaseUrl') | |
| : getWebhookBaseUrl(); | |
| const n8nBaseUrl = config.get('editorBaseUrl') || getWebhookBaseUrl(); |
krynble
force-pushed
the
user-management-editor-uri
branch
from
4cd984c to
450508d
Compare
mutdmour
approved these changes
Mar 14, 2022
n8n-assistant
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.