Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Email Read Imap node #2991

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Improvements to Email Read Imap node #2991

merged 3 commits into from
Mar 19, 2022

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Mar 15, 2022

This PR makes some small changes to #2485

Basically we are sending errors to logger, that should work according to tests I've made. The approach of wrapping errors in .error property won't solve the problem since n8n will handle this as a successful execution, which would be unexpected.

@Joffcom Joffcom added node/improvement New feature or request community Authored by a community member n8n team Authored by the n8n team labels Mar 16, 2022
@janober janober merged commit 846e866 into master Mar 19, 2022
@janober janober deleted the n8n-3073-node-improvement-pr-2485--fix branch March 19, 2022 19:03
@janober janober added the Upcoming Release Will be part of the upcoming release label Mar 19, 2022
@janober
Copy link
Member

janober commented Mar 19, 2022

Thanks a lot. Got merged.

@janober janober mentioned this pull request Mar 19, 2022
Closed
@janober
Copy link
Member

janober commented Mar 20, 2022

Got released with n8n@0.169.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 20, 2022
Wowasshi pushed a commit to IT-Global-SVC/n8n that referenced this pull request Mar 30, 2022
@janober @Joffcom
@RicardoE105 @tennox @Yann-J @marcinkoziej @nivbe06 @michael-radency @m4tt72 @Wowasshi
feat(editor): Add download button for binary data (n8n-io#2992)
c06e7f5 
* ✨ Make it possible to download binary data

* ⚡ Fix lint issues and add support for filesystem mode

* ⚡ Design adjustment

📜 Change to the Sustainable Use License n8n-io#2932

🚨 Temporarily skip some regularly failing tests (n8n-io#3002)

feat: Add support for reading ids from file with executeBatch command (n8n-io#3008)

feat(Mattermost Node): Add support for Channel Search (n8n-io#2687)

* Squashed commit of the following:

commit 9f76bdca9b4af4fd3ee429d1c381c3ed5529434c
Author: Matt Walther <matt@mashio.net>
Date:   Sun Jan 16 16:40:34 2022 -0600

    Mattermost Channel Search

* Add more boilerplate so Search action renders

* Changed order of search to make the operations alphabetical

* :zap: Add pagination

bug(EmailReadImap Node): Improve error handling (n8n-io#2991)

* Fix: EmailReadImap unhandled promise rejection

Related to n8n-io#2091 (but only partially)

See n8n-io#2091 (comment)

* Send errors from email read imap to logger

feat(HTTP Request Node): Allow Delete requests with body (n8n-io#2900)

delete request with body parameters

feat(KoBoToolbox Node): Add KoBoToolbox Regular and Trigger Node (n8n-io#2765)

* First version

* Added hooks

* Added Credentials test

* Add support for downloading attachments

* Slight restructure of downloaded binaries

* Added Trigger node

* Some linting

* Reverting package-lock changes

* Minor GeoJSON parsing fixes

* KoboToolbox: improve GeoJSON format

* Kobo: Support for get/set validation status

* Remove some logs

* [kobo] Fix default attachment options

* Proper debug logging

* Support for hook log status filter

* Kobo: Review fixes

* [kobo]: Add Get All Forms + lookup Form ID

* [kobo] Lookup Form ID in Trigger node

* [kobo] Update branded spelling

* [kobo] Support pagination

* ⚡ fix linting issue

* ⚡ Improvements to n8n-io#2510

* ⚡ Download files using n8n helper

* ⚡ Improvements

* ⚡ Improvements

* 🐛 Fix filenames

* ⚡ Fix some issues

feat(Linear Node): Add Linear Node (n8n-io#2971)

* ✨ Linear node

* ⚡ Improvements

fix(GitHub Node): Fix credential tests and  File > List operation (n8n-io#2999)

* Fixed credential test failing

* Fixed File list operation not working

fix(Telegram Node): Fix sending binary data when disable notification is set (n8n-io#2990)

feat(Mailjet Node): Add credential tests and support for sandbox, JSON parameters & variables (n8n-io#2987)

* Add Variables JSON to Mailjet Batch send

* ⚡ Improvements

* ⚡ Add credential verification

* ⚡ Small improvement

⬆️ Update package-lock.json file

🔖 Release n8n-workflow@0.92.0

⬆️ Set n8n-workflow@0.92.0 on n8n-core

🔖 Release n8n-core@0.110.0

⬆️ Set n8n-core@0.110.0 and n8n-workflow@0.92.0 on n8n-node-dev

🔖 Release n8n-node-dev@0.49.0

⬆️ Set n8n-core@0.110.0 and n8n-workflow@0.92.0 on n8n-nodes-base

🔖 Release n8n-nodes-base@0.167.0

🔖 Release n8n-design-system@0.15.0

⬆️ Set n8n-design-system@0.15.0 and n8n-workflow@0.92.0 on n8n-editor-ui

🔖 Release n8n-editor-ui@0.136.0

⬆️ Set n8n-core@0.110.0, n8n-editor-ui@0.136.0, n8n-nodes-base@0.167.0 and n8n-workflow@0.92.0 on n8n

🔖 Release n8n@0.169.0

📚 Update CHANGELOG.md

📚 Fix CHANGELOG.md file

⚡ Add Odoo and RedisTrigger node codex (n8n-io#3005)

* .168.2fixed: Auto stash before rebase of "refs/heads/codex/0.168.2fixed"

Odoo and Redis Trigger codex files update

* Update RedisTrigger.node.json

:zap: Add KoBoToolbox and Linear codex files (n8n-io#3040)

KoBoToolbox
KoBoToolbox Trigger
Linear

:books: Add missing full stop to license text

* (fix): Added missing full stop to license

GitHub does not render the single line breaks in the *Limitations* section. The added full stop makes it easier to read our license.

* :books: Add also to other files

fix(AWS Lambda Node): Fix "Invocation Type" > "Continue Workflow" (n8n-io#3010)

* 🔨 fix for running in continue workflow

* ⚡ Minor simplification

📚 Add one more missing full stop to license text

fix(core): Add logs and error catches for possible failures in queue mode (n8n-io#3032)

fix(Supabase Node): Fix Row > Get operation (n8n-io#3045)

fix(Supabase Node): Send token also via Authorization Bearer (n8n-io#2814)

Send Authorization Bearer in headers
Fix typo in validateCredentials function

fix(Wise Node): Fix issue when executing a transfer (n8n-io#3039)

:zap: Fix credentials import success message (n8n-io#3038)

:books: Add missing full stop to license text (n8n-io#3028)

Adding "." L15.

In addition, the markdown display don't show line break as in the editor.

:books: Add note to changelog linking to historic log (n8n-io#3031)

feat(HTTP Request Node): Add support for OPTIONS method (n8n-io#3030)

fix(Xero Node): Fix some operations and add support for setting address and phone number (n8n-io#3048)

* 🐛 Fix issue when sending Organization ID - Xero node

* 👕 Fix linting issue

feat(Crypto Node): Add Generate operation to generate random values (n8n-io#2541)

* ✨ Add generate action to crypto node

* ⚡ small fixes, nodelinter issues fixes

* ⚡ Improvements

* ⚡ Fix order

feat(Reddit Node): Add possibility to query saved posts (n8n-io#3034)

* chore: add nvmrc with required node version

* feat: added saved posts to reddit node with credentials on User resource

* Changed Details order

* Fixed lint issue

* Moved saved posts to profile as it only works for the logged in user, This avoids the breaking change

* Removed .nvmrc

* ⚡ Improvements

feat(Jira Node): Add Simplify Output option to Issue > Get (n8n-io#2408)

* ✨ Add option to use Jira field display names

* 🚸 Make mapped fields more deterministic

* ♻️ Refactor Jira user loadOptions

* Moved and renamed the option as well as only returning the fields to

* Tweaked Friendly Fields to make it "Simplify Output" following similar patterns to other nodes

* ⚡ Improvements

feat(Zendesk Node): Add ticket status "On-hold"

🔖 Release n8n-workflow@0.93.0

⬆️ Set n8n-workflow@0.93.0 on n8n-core

🔖 Release n8n-core@0.111.0

⬆️ Set n8n-core@0.111.0 and n8n-workflow@0.93.0 on n8n-node-dev

🔖 Release n8n-node-dev@0.50.0

⬆️ Set n8n-core@0.111.0 and n8n-workflow@0.93.0 on n8n-nodes-base

🔖 Release n8n-nodes-base@0.168.0

🔖 Release n8n-design-system@0.16.0

⬆️ Set n8n-design-system@0.16.0 and n8n-workflow@0.93.0 on n8n-editor-ui

🔖 Release n8n-editor-ui@0.137.0

⬆️ Set n8n-core@0.111.0, n8n-editor-ui@0.137.0, n8n-nodes-base@0.168.0 and n8n-workflow@0.93.0 on n8n

🔖 Release n8n@0.170.0

⬆️ Update package-lock.json file

📚 Update CHANGELOG.md with version 0.170.0

Co-Authored-By: Jonathan Bennetts <jonathan.bennetts@gmail.com>
Co-Authored-By: ricardo <ricardoespinoza105@gmail.com>
Co-Authored-By: Manuel [tennox] <2084639+tennox@users.noreply.github.com>
Co-Authored-By: Justin Halter <jhalter@weare5stones.com>
Co-Authored-By: Yann Jouanique <yann.jouanique@oneacrefund.org>
Co-Authored-By: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-Authored-By: Marcin Koziej <marcin@cahoots.pl>
Co-Authored-By: Niv <nivbelleli@gmail.com>
Co-Authored-By: michael-radency <michael.k@radency.com>
Co-Authored-By: Yassine Fathi <hi@m4tt72.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Authored by a community member n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krynble @janober @Joffcom @tennox