Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implements PayPal Auth API Test #3023

Closed
wants to merge 2 commits into from
Closed

✨ Implements PayPal Auth API Test #3023

wants to merge 2 commits into from

Conversation

paolo-rechia
Copy link
Contributor

Implements PayPal API Credentials test.

Implementation Strategy:
Given the credentials, attempt to exchange for an access token.

Proof of Functionality

Invalid credentials:
image

Valid credentials:
image

Caveats

  • Has not been tested in Live environment, since I only have access to Sandbox.
  • Not sure why documentation on PayPal uses api-m in the endpoint domain, while the code in PayPal node uses only api. If possible, please double check that this OK.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2022

CLA assistant check
All committers have signed the CLA.

@Joffcom Joffcom added node/improvement New feature or request community Authored by a community member labels Mar 22, 2022
@Joffcom
Copy link
Member

Joffcom commented Apr 4, 2022

Hey @paolo-rechia,

I was not able to push changes to your branch / this PR so I have created #3084 which includes a few tweaks to this one and adds in a couple of changes from another PR.

I am going to mark this one as closed, Thanks for the PR and let me know if you have any questions 👍🏻

@Joffcom Joffcom closed this Apr 4, 2022
@janober
Copy link
Member

janober commented Apr 8, 2022

Thanks a lot for your contribution @paolo-rechia. Got merged with #3084

@janober janober added the Upcoming Release Will be part of the upcoming release label Apr 8, 2022
@janober
Copy link
Member

janober commented Apr 11, 2022

Got released with n8n@0.172.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants