Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch block to avoid crashes when running in queue mode #3397

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add catch block to avoid crashes when running in queue mode #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef26539
Add catch block to avoid crashes when running in queue mode
krynble May 30, 2022
d46fbfe
Throwing errors that happen in worker so process stops
krynble Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/commands/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ export class Worker extends Command {
process.exit(2);
} else {
logger.error('Error from queue: ', error);
throw error;
}
});

Expand Down
6 changes: 6 additions & 0 deletions packages/cli/src/WorkflowRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,12 @@ export class WorkflowRunner {
},
);

workflowExecution.catch(() => {
// We `reject` this promise if the execution fails
// but the error is handled already by processError
// So we're just preventing crashes here.
});

this.activeExecutions.attachWorkflowExecution(executionId, workflowExecution);
return executionId;
}
Expand Down