Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N8n 3196 trigger panel #3509

Merged
merged 107 commits into from
Jun 20, 2022
Merged

N8n 3196 trigger panel #3509

merged 107 commits into from
Jun 20, 2022

Conversation

mutdmour
Copy link
Contributor

No description provided.

mutdmour added 30 commits June 1, 2022 14:54
@mutdmour
add panel
4aaaa55
@mutdmour
add workflow activation hints
34ed545
@mutdmour
support service trigger nodes
1ebbd14
@mutdmour
update polling state
3fefa87
@mutdmour
support more views
d3524be
@mutdmour
Merge branch 'master' of github.com:n8n-io/n8n into n8n-3196-trigger-…
b622567 
…views
@mutdmour
update when trigger panel shows
9d96b22
@mutdmour
update start/error nodes
8caa6e9
@mutdmour
add cron/interval info box
760b5c0
@mutdmour
clean up start node
563027e
@mutdmour
fix up webhook views
77847f9
@mutdmour
remove console log
a8bd1b5
@mutdmour
merge in masteR
6f1c866
@mutdmour
add listening state
a971ae3
@mutdmour
clean up loading state
f87ef13
@mutdmour
update loading state
4aae1c3
@mutdmour
fix up animation
df798f4
@mutdmour
update views
e6eba7b
@mutdmour
add executions hint
ea903a5
@mutdmour
update views
e4b3545
@mutdmour
update accordian styling
f46a9bb
@mutdmour
address more issues
f7f0de9
@mutdmour
disable execute button if issues
3d7aabd
@mutdmour
disable if it has issues
39f4616
@mutdmour
add stop waiting button
27419c8
@mutdmour
can activate workflow when dsiabled
f9c61e2
@mutdmour
update el
f520682
@mutdmour
fix has issues
671f442
@mutdmour
add margin bttm
bdf3e06
@mutdmour
update views
ddd7916
@mutdmour mutdmour marked this pull request as ready for review June 17, 2022 13:16
@mutdmour mutdmour changed the title N8n 3196 trigger views N8n 3196 trigger panel Jun 17, 2022
MiloradFilipovic
MiloradFilipovic approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left a few comments.

packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue Show resolved Hide resolved
packages/editor-ui/src/components/InfoAccordion.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/NodeExecuteButton.vue Outdated Show resolved Hide resolved
packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue Show resolved Hide resolved
@janober janober merged commit a2f6289 into master Jun 20, 2022
@janober janober deleted the n8n-3196-trigger-views branch June 20, 2022 19:39
@janober
Copy link
Member

janober commented Jun 20, 2022

Thanks a lot. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Jun 20, 2022
@janober
Copy link
Member

janober commented Jun 21, 2022

Got released with n8n@0.183.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @MiloradFilipovic