✨ Telemetry updates #3529

ahsanv · 2022-06-16T16:17:15Z

No description provided.

mutdmour · 2022-07-04T12:13:35Z

packages/cli/src/InternalHooks.ts

+					if (nodeGraphResult.webhookNodeName) {
+						manualExecEventProperties.webhook_domain = pslGet(
+							(
+								runData.data.resultData.runData[nodeGraphResult.webhookNodeName]?.[0]?.data
+									?.main?.[0]?.[0]?.json as { headers: { host: string } }
+							).headers.host,
+						);


What's the goal here? Would not this be just mutasem.app.n8n.cloud the whole time for my cloud instance?
Also what if there's multiple webhook nodes? Is that handled? If I understand this implementation correctly, it will only return the last webhook node, whether it has run data or not

pslGet shall return just the domain, without subdomain part. in case of mutasem.app.n8n.cloud it should return n8n.cloud and that is what we need here.
Thanks for pointing out multiple webhook case though, fixed 🙏

mutdmour · 2022-07-04T12:23:08Z

packages/workflow/src/Interfaces.ts

@@ -1475,6 +1475,15 @@ export type PropertiesOf<M extends { resource: string; operation: string }> = Ar

 // Telemetry

+export interface ITelemetryTrackProperties {
+	user_id?: string;
+	[key: string]: string | number | boolean | object | undefined | null;


can use GenericValue here instead

mutdmour · 2022-07-04T12:34:15Z

packages/editor-ui/src/plugins/telemetry/index.ts

+				...properties,
+				version_cli: this.store && this.store.getters.versionCli,


should not this be a trait instead the way we add instance id and user id

yes. we already have it as a trait, but with this change, we are adding version as a property in all events.

I don't think it is right now based on a quick look at the code.

n8n/packages/editor-ui/src/plugins/telemetry/index.ts

Line 81 in 9864805

this.telemetry.identify(`${instanceId}#${userId}`, traits);

should not it suffice as a trait? instead of adding it as a property to every request?

mutdmour · 2022-07-04T12:36:50Z

packages/editor-ui/src/components/mixins/workflowRun.ts

 						for (const nodeName of Object.keys(workflowIssues)) {
 							nodeIssues = NodeHelpers.nodeIssuesToString(workflowIssues[nodeName]);
+							const issueNodeType = this.$store.getters.getNodeByName(nodeName).type.split('.')[1];


getNodeByName could return null

mutdmour · 2022-07-04T12:45:20Z

packages/editor-ui/src/components/ExpressionEdit.vue

+			if (eventData.variable) {
+				let splitVar = eventData.variable.split('.');
+
+				if(eventData.variable.startsWith('Object.keys')) {


nipick - spacing here and below

Suggested change

if(eventData.variable.startsWith('Object.keys')) {

if (eventData.variable.startsWith('Object.keys')) {

packages/editor-ui/src/views/NodeView.vue

mutdmour · 2022-07-07T08:33:42Z

packages/editor-ui/src/plugins/telemetry/index.ts

+				...properties,
+				version_cli: this.store && this.store.getters.versionCli,


I don't think it is right now based on a quick look at the code.

n8n/packages/editor-ui/src/plugins/telemetry/index.ts

Line 81 in 9864805

this.telemetry.identify(`${instanceId}#${userId}`, traits);

should not it suffice as a trait? instead of adding it as a property to every request?

packages/editor-ui/src/components/mixins/workflowRun.ts

* add webhook_domain property in manual execution event * lint fix

janober · 2022-07-10T06:53:13Z

Thanks a lot. Got merged.

…ndex refresh (#2420) * 🐛 ES query string not passed to request * 🔑 Add ES credential test * ✨ Add ES index pipelines and index refresh * 🔨 merge fix * ⚡ renamed additional filds as options * ⚡ added ignore ssl to credentials * ⚡ Improvements * ⚡ Improvements * feat(Redis Node): Add push and pop operations (#3127) * ✨ Add push and pop operations * ⚡ linter fixes * ⚡ linter fixes * 🐛 Fix errors and remove overwrite * 🐛 Remove errant hint * ⚡ Small change Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor: Telemetry updates (#3529) * Init unit tests for telemetry * Update telemetry tests * Test Workflow execution errored event * Add new tracking logic in pulse * cleanup * interfaces * Add event_version for Workflow execution count event * add version_cli in all events * add user saved credentials event * update manual wf exec finished, fixes * improve typings, lint * add node_graph_string in User clicked execute workflow button event * add User set node operation or mode event * Add instance started event in FE * Add User clicked retry execution button event * add expression editor event * add input node type to add node event * add User stopped workflow execution wvent * add error message in saved credential event * update stop execution event * add execution preflight event * Remove instance started even tfrom FE, add session started to FE,BE * improve typing * remove node_graph as property from all events * move back from default export * move psl npm package to cli package * cr * update webhook node domain logic * fix is_valid for User saved credentials event * fix Expression Editor variable selector event * add caused_by_credential in preflight event * undo webhook_domain * change node_type to full type * add webhook_domain property in manual execution event (#3680) * add webhook_domain property in manual execution event * lint fix * feat(SpreadsheetFile Node): Allow skipping headers when writing spreadsheets (#3234) * ⚡ Allow skipping headers when writing spreadsheets * Fix type on sheet options * fix(Telegram Node): Fix sending binaryData media (photo, document, video etc.) (#3408) * fixed send media (photo, document, video etc.) issues on Telegram Node * fixed send media (photo, document, video etc.) issues on Telegram Node * file name is optional now * ⚡ lock file and linter fix * ⚡ improvements * ⚡ fixes * ⚡ Improvements * ⚡ Add placeholder to File Name * ⚡ Add error message * 🔥 Remove requestWithAuthentication * ⚡ Fix typo * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Freshworks CRM Node): Add Search + Lookup functionality (#3131) * Add fields and Ops for Lookup Search * Adds Search (Search + Lookup) operations * 🔨 credentials update * 🔨 improvements * ⚡ clean up and linter fixes * ⚡ merged search and query, more hints * ⚡ Improvements * ⚡ Add generic type to authentication method Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Jira Trigger Node): Add optional query auth for security (#3172) * ✨ Add query auth for Jira Trigger security * ⚡ small fixes: * ⚡ Response with 403 when invalid query authentication * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * ⚡ Changed authentication to use the generic type Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Ahsan Virani <ahsan.virani@gmail.com> Co-authored-by: Nicholas Penree <nick@penree.com> Co-authored-by: Taha Sönmez <35905778+tahasonmez@users.noreply.github.com> Co-authored-by: Jan Thiel <JanThiel@users.noreply.github.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

janober · 2022-07-13T08:42:59Z

Got released with n8n@0.186.0

* upstream merge * ⚡ version 2 support for trigger * ⚡ lock fix * ⚡ typo fix * fix(core): Fix logger error when logging circular json (#3583) * Fix logger error when logging circular json * add type * feat: Migrated to npm release of riot-tmpl fork (#3581) * feat: Migrated to npm release of riot-tmpl fork. * fix: Updated imports to use @n8n_io/riot-tmpl * fix: Fixed Logger.ts types. Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * fix: Fix issue with required optional parameters (#3577) * fix: Correct misfix from `node-param-display-name-wrong-for-dynamic-multi-options` (#3575) * 👕 Correct misfix * 👕 Fix build * fix(editor): Fix credentials rendering when the node has no parameters (#3563) * test: Fix failing tests on MySQL for Public API (#3520) * ⚡ Generalize transformer * ⚡ Use transformer * 🧪 Fix expectations * fix(LinkedIn Node): Fix LinkedIn image preview (#3528) * Fixed issue with Preview not being generated when description and title is blank * Nodelinter fixes * Fixed lint issue... build should work Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * ⚡ Improvements * fix: Fix issue with required optional parameters (#3597) * Fixed issue with Reddit node not getting all posts * Fixed remaining issues with required options * test: Make oclif commands testable (#3571) * ➕ Add `@oclif/core` * 📦 Update `package-lock.json` * 📘 Export `Logger` for use as type * ✨ Create `BaseCommand` * 🐛 Prevent DB re-init * ♻️ Refactor `reset` command * 🧪 Fix `reset` test * 👕 Add lint exception Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * fix(HTTP Request Node): Make all OAuth2 credentials work with HTTP Request Node (#3503) * fix(Salesforce Node): Fix issue with lead status not using name on update (#3599) * Fixed issue with lead status not using name on update * 🔥 Remove unnecessary line Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor: Automatically add fileExtension from FileTypeResult to binary data (#3591) * ♻️ Add fileExtension from FileTypeResult to buffer data * ⚡ Minor improvement Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> * feat(core): Expose item index being processed (#3590) * 🧑‍💻 Expose item index being processed * ✅ Fix tests for getCurrentItemIndex * ✅ Fix tests for getCurrentItemIndex * ⚡ Rename method Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> * feat(core) Simplify authentication type (#3578) * ⚡ Add generic auth type * ⚡ Remove queryAuth * ⚡ Remove bearer * ⚡ Remove headerAuth * ⚡ Remove basicAuth * ⚡ Adjust tests * ⚡ Small improvements * 👕 Fix lint issue * fix(editor): Display full text of long error messages (#3561) * feat(core): Give access to getBinaryDataBuffer in preSend method (#3588) * fix(Cortex Node): Fix issue that not all Analyzers got returned (#3606) * Updated Cortex analyzer search url to fetch all * Updated Cortex credentials * Nodelinter fixes * More fixes * feat(Clockify Node): Add more resources and improvements (#3411) * ✨ Add more Clockify resources * Moved headers in credentials file and added testing * add address to additional fields * Add pagination to workflow * 🎨 Rename additional fields to filter * Remove non-required fields to additional fields * 🔥 Remove loading of client id * ⚡ Improvements * ⚡ Small change Co-authored-by: pemontto <pemontto@gmail.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * ⬆️ Update package-lock.json file * 🔖 Release n8n-workflow@0.106.0 * ⬆️ Set n8n-workflow@0.106.0 on n8n-core * 🔖 Release n8n-core@0.124.0 * ⬆️ Set n8n-core@0.124.0 and n8n-workflow@0.106.0 on n8n-node-dev * 🔖 Release n8n-node-dev@0.63.0 * ⬆️ Set n8n-core@0.124.0 and n8n-workflow@0.106.0 on n8n-nodes-base * 🔖 Release n8n-nodes-base@0.182.0 * ⬆️ Set n8n-workflow@0.106.0 on n8n-editor-ui * 🔖 Release n8n-editor-ui@0.150.0 * ⬆️ Set n8n-core@0.124.0, n8n-editor-ui@0.150.0, n8n-nodes-base@0.182.0 and n8n-workflow@0.106.0 on n8n * 🔖 Release n8n@0.184.0 * 🔖 Update main package.json to 0.184.0 * 📚 Update CHANGELOG.md with version 0.184.0 * 🧪 Truncate mapping tables * 🧪 Add DB init timeout * 🧪 Separate statements when clearing mappings in MySQL * 🧪 Hide logging during tests * 🧪 Make PG truncation sequential * 🧪 Add missing SMTP timeout * 🎨 Formatting fixes * feat(Wordpress Node): Add post template option (#3139) * Add wordpress post template option * Fix: Add UI components and fix typo * Add elementor template options * Add Standard option * 🔨 ability to use non elementor template, credential test, linter fixes * 🔨 removed commented code * ⚡ Improvements Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor(Notion Node): Add content access note to Notion Trigger (#3625) * Added notice to Notion trigger * Changed position * fix(Todoist Node): Fix multiple item support (#3614) * Fixed multiple items handling with todoist node * Removed unused import * fix(Hubspot Node): Fix search endpoints (#3640) * Fixed Hubspot search endpoints * 👕 Fix lint issue Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> * feat: Add debug configuration file with instructions (#3631) * Add debug configuration file with instructions * Add debugger.md file for clarifications * Moved debugger file to vscode folder * feat(Webflow Trigger Node): Reduce chance of webhook duplication and add credential test (#3594) * upstream merge * ⚡ additional check for webhook, credentials update * 🔥 Remove unnecessary condition * ⚡ Change credential injection to generic type * 👕 Fix linting issue Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * fix(Odoo Node): Prevent possible issues with some custom fields (#3496) * ci: Using npm ci instead of npm install to reuse package-lock.json (#3648) * refactor: Apply more `eslint-plugin-n8n-nodes-base` rules (#3624) * ⬆️ Upgrade `eslint-plugin-n8n-nodes-base` * 📦 Update `package-lock.json` * 🔧 Adjust renamed filesystem rules * ✏️ Alphabetize ruleset * ⚡ Categorize overrides * ⚡ Set renamings in lint exceptions * ⚡ Run baseline `lintfix` * ⚡ Update linting scripts * 👕 Apply `node-param-description-missing-from-dynamic-multi-options` * 👕 Apply `cred-class-field-name-missing-oauth2` (#3627) * Rule working as intended * Removed comments * Move cred rule to different rule set * 👕 Apply `node-param-array-type-assertion` * 👕 Apply `node-dirname-against-convention` * Apply `cred-class-field-display-name-oauth2` (#3628) * Apply `node-execute-block-wrong-error-thrown` * Apply `node-class-description-display-name-unsuffixed-trigger-node` * Apply `node-class-description-name-unsuffixed-trigger-node` * Apply `cred-class-name-missing-oauth2-suffix` (#3636) * Rule working as intended, add exception to existing nodes * 👕 Apply `cred-class-field-name-uppercase-first-char` (#3638) * ⬆️ Upgrade to plugin version 1.2.28 * 📦 Update `package-lock.json` * 👕 Update lintings with 1.2.8 change * 👕 Apply `cred-class-field-name-unsuffixed` * 👕 Apply `cred-class-name-unsuffixed` * 👕 Apply `node-class-description-credentials-name-unsuffixed` * ✏️ Alphabetize rules * ➖ Remove `nodelinter` package * 📦 Update `package-lock.json` * ⚡ Consolidate `lint` and `lintfix` scripts Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com> Co-authored-by: agobrech <ael.gobrecht@gmail.com> * feat(Jira Node): Use Jira rendered fields with simplify option (#3323) * 💄 Use Jira rendered fields with simplify * 🐛 Merge the renderedField results with fields * ⚡ improvements * ⚡ Improvements Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * ci: Fix Vue build issues (#3650) * lock vue versions to patch. Not use docker cache in nightly builds * revert to using npm install * ⬆️ Update package-lock.json file * fix(Sticky Node): Fix main header hiding (#3654) * feat(core): Add `action` to `INodePropertyOptions` (#3610) * 📘 Add `action` to `INodeProperties` * 📘 Add `action` to `INodePropertyOptions` * 🔥 Remove unneeded key * fix(KoboToolbox Node): Improve attachment matching logic and GeoJSON Polygon format (#3394) * Fix query,sort + use question name in attachments * Change Menu structure * kobo: Clearer webhook name * [kobo]: fix when no json filter * Fix ambiguous attachment matching + GeoJSON Polygon format * Fix kobo function * Fix extra descriptions * fix(KoboToolbox Node): Improve attachment matching logic and GeoJSON Polygon format (#3535) * Fix query,sort + use question name in attachments * Change Menu structure * kobo: Clearer webhook name * [kobo]: fix when no json filter * Fix ambiguous attachment matching + GeoJSON Polygon format * Fix kobo function * Fix extra descriptions * Add credentials injection and testing * Fix credential injection and lint issues Co-authored-by: Yann Jouanique <yann.jouanique@oneacrefund.org> Co-authored-by: Yann Jouanique <yann.jouanique@gmail.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * feat(Google Ads Node): Add new node (#3526) * Add basic layout with icon for Google Ads * Add node versioning(V1) * Add node and credential to package * Add basic layout with icon for Google Ads * Add node versioning(V1) * Add node and credential to package * Add api call to getall * Fix formdata in the body for the request * N8N-2928 Added custom queries to campaign * Fix header bug and add developer-token field * Add operation and fields to campaign new format * Add more configurations and queries * Add Invoice ressources and operations * Remov old version from the node * Fixed bud with typo * Correctly prepends the baseURL * add query to invocie request * Fixes header not parsing the expression * Invoice param changes * Fixes bug related to headers not being parsed, and bug with auth * Remove useless imports * Added analytics to google ad node and removed useless header * Removed url for testing * Fixed inconsistent behaviour with the access token not being refreshed * Added placeholders to help user * Removed useless comments * Resolved name confusion * Added support for body in a GET method * Removed hyphens, parse body's expression * Renamed operation for clarity * Remove unused code * Removed invoice resource and fixed bug with body and headers The invoice operation was removed since it does not reflect what a user would expect from it. Google ADS invoices are only used for big advertisers where invoicing is performed after the end of the month and for big sums. This would be misleading for the majority of the users expecting an expenses report. Also fixed a bug with header and body being sent since it was broken for multiple input rows. The first execution would override all others. Lastly, made some improvements to the node itself by transforming data, adding filters and operations. * Improve campagin operation and remove analytics; fix tests * Improve tooltips and descriptions * Fix lint issues * Improve tooltip to explain amounts in micros * Change wording for micros * Change the fix to a more elegant solution Co-authored-by: Cyril Gobrecht <cyril.gobrecht@gmail.com> Co-authored-by: Aël Gobrecht <ael.gobrecht@gmail.com> * feat(DeepL Node): Add support for longer texts + Credential tests (#3651) * Updated DeepL to send data with Body instead of QS allowing larger translations * Updated Credentials and added test * feat(Facebook Node): Add support for Facebook Graph API versions 14 (#3656) * ⬆️ Update package-lock.json file * ⬇️ Downgrading fontawesome to v5 (#3658) * ⬆️ Update package-lock.json file * 🔖 Release n8n-workflow@0.107.0 * ⬆️ Set n8n-workflow@0.107.0 on n8n-core * 🔖 Release n8n-core@0.125.0 * ⬆️ Set n8n-core@0.125.0 and n8n-workflow@0.107.0 on n8n-node-dev * 🔖 Release n8n-node-dev@0.64.0 * ⬆️ Set n8n-core@0.125.0 and n8n-workflow@0.107.0 on n8n-nodes-base * 🔖 Release n8n-nodes-base@0.183.0 * 🔖 Release n8n-design-system@0.25.0 * ⬆️ Set n8n-design-system@0.25.0 and n8n-workflow@0.107.0 on n8n-editor-ui * 🔖 Release n8n-editor-ui@0.151.0 * ⬆️ Set n8n-core@0.125.0, n8n-editor-ui@0.151.0, n8n-nodes-base@0.183.0 and n8n-workflow@0.107.0 on n8n * 🔖 Release n8n@0.185.0 * 🔖 Update main package.json to 0.185.0 * 📚 Update CHANGELOG.md with version 0.185.0 * feat(Redis Node): Add push and pop operations (#3127) * ✨ Add push and pop operations * ⚡ linter fixes * ⚡ linter fixes * 🐛 Fix errors and remove overwrite * 🐛 Remove errant hint * ⚡ Small change Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor: Telemetry updates (#3529) * Init unit tests for telemetry * Update telemetry tests * Test Workflow execution errored event * Add new tracking logic in pulse * cleanup * interfaces * Add event_version for Workflow execution count event * add version_cli in all events * add user saved credentials event * update manual wf exec finished, fixes * improve typings, lint * add node_graph_string in User clicked execute workflow button event * add User set node operation or mode event * Add instance started event in FE * Add User clicked retry execution button event * add expression editor event * add input node type to add node event * add User stopped workflow execution wvent * add error message in saved credential event * update stop execution event * add execution preflight event * Remove instance started even tfrom FE, add session started to FE,BE * improve typing * remove node_graph as property from all events * move back from default export * move psl npm package to cli package * cr * update webhook node domain logic * fix is_valid for User saved credentials event * fix Expression Editor variable selector event * add caused_by_credential in preflight event * undo webhook_domain * change node_type to full type * add webhook_domain property in manual execution event (#3680) * add webhook_domain property in manual execution event * lint fix * feat(SpreadsheetFile Node): Allow skipping headers when writing spreadsheets (#3234) * ⚡ Allow skipping headers when writing spreadsheets * Fix type on sheet options * fix(Telegram Node): Fix sending binaryData media (photo, document, video etc.) (#3408) * fixed send media (photo, document, video etc.) issues on Telegram Node * fixed send media (photo, document, video etc.) issues on Telegram Node * file name is optional now * ⚡ lock file and linter fix * ⚡ improvements * ⚡ fixes * ⚡ Improvements * ⚡ Add placeholder to File Name * ⚡ Add error message * 🔥 Remove requestWithAuthentication * ⚡ Fix typo * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Freshworks CRM Node): Add Search + Lookup functionality (#3131) * Add fields and Ops for Lookup Search * Adds Search (Search + Lookup) operations * 🔨 credentials update * 🔨 improvements * ⚡ clean up and linter fixes * ⚡ merged search and query, more hints * ⚡ Improvements * ⚡ Add generic type to authentication method Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Jira Trigger Node): Add optional query auth for security (#3172) * ✨ Add query auth for Jira Trigger security * ⚡ small fixes: * ⚡ Response with 403 when invalid query authentication * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Elasticsearch Node): Add credential tests, index pipelines and index refresh (#2420) * 🐛 ES query string not passed to request * 🔑 Add ES credential test * ✨ Add ES index pipelines and index refresh * 🔨 merge fix * ⚡ renamed additional filds as options * ⚡ added ignore ssl to credentials * ⚡ Improvements * ⚡ Improvements * feat(Redis Node): Add push and pop operations (#3127) * ✨ Add push and pop operations * ⚡ linter fixes * ⚡ linter fixes * 🐛 Fix errors and remove overwrite * 🐛 Remove errant hint * ⚡ Small change Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor: Telemetry updates (#3529) * Init unit tests for telemetry * Update telemetry tests * Test Workflow execution errored event * Add new tracking logic in pulse * cleanup * interfaces * Add event_version for Workflow execution count event * add version_cli in all events * add user saved credentials event * update manual wf exec finished, fixes * improve typings, lint * add node_graph_string in User clicked execute workflow button event * add User set node operation or mode event * Add instance started event in FE * Add User clicked retry execution button event * add expression editor event * add input node type to add node event * add User stopped workflow execution wvent * add error message in saved credential event * update stop execution event * add execution preflight event * Remove instance started even tfrom FE, add session started to FE,BE * improve typing * remove node_graph as property from all events * move back from default export * move psl npm package to cli package * cr * update webhook node domain logic * fix is_valid for User saved credentials event * fix Expression Editor variable selector event * add caused_by_credential in preflight event * undo webhook_domain * change node_type to full type * add webhook_domain property in manual execution event (#3680) * add webhook_domain property in manual execution event * lint fix * feat(SpreadsheetFile Node): Allow skipping headers when writing spreadsheets (#3234) * ⚡ Allow skipping headers when writing spreadsheets * Fix type on sheet options * fix(Telegram Node): Fix sending binaryData media (photo, document, video etc.) (#3408) * fixed send media (photo, document, video etc.) issues on Telegram Node * fixed send media (photo, document, video etc.) issues on Telegram Node * file name is optional now * ⚡ lock file and linter fix * ⚡ improvements * ⚡ fixes * ⚡ Improvements * ⚡ Add placeholder to File Name * ⚡ Add error message * 🔥 Remove requestWithAuthentication * ⚡ Fix typo * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Freshworks CRM Node): Add Search + Lookup functionality (#3131) * Add fields and Ops for Lookup Search * Adds Search (Search + Lookup) operations * 🔨 credentials update * 🔨 improvements * ⚡ clean up and linter fixes * ⚡ merged search and query, more hints * ⚡ Improvements * ⚡ Add generic type to authentication method Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Jira Trigger Node): Add optional query auth for security (#3172) * ✨ Add query auth for Jira Trigger security * ⚡ small fixes: * ⚡ Response with 403 when invalid query authentication * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * ⚡ Changed authentication to use the generic type Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Ahsan Virani <ahsan.virani@gmail.com> Co-authored-by: Nicholas Penree <nick@penree.com> Co-authored-by: Taha Sönmez <35905778+tahasonmez@users.noreply.github.com> Co-authored-by: Jan Thiel <JanThiel@users.noreply.github.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> * feat(Postgres Node): Improvement handling of large numbers (#3360) * 🔨 fix * ⚡ ui update * feat(Customer.io Node): Add support for tracking API region selection (#3378) * support for customer.io tracking api endpoint region selection If your account is based in our EU region use the EU endpoints (track-eu.customer.io) for US (other than EU) tracking endpoints (track.customer.io). * Changed name to keep constistency with other nodes * Switched to credentials injection * Add throwing error when unknow way of authenticating * Fixed url for http request * Add hint to region field about being omited with http node * Fix bug for credentials working with http node * Improve IF by deduplicating code Co-authored-by: h4ux <alon@h4ux.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> * feat(AWS DynamoDB Node): Improve error handling + add optional GetAll Scan FilterExpression (#3318) * FilterExpression, ExpressionAttributeValues optional * Returns AWS JSON messages not in response body * 🔨 fixed filterExpression missing in request body * ⚡ linter fixes * Reintroduced 'fix' block at :311 results in duplication * ⚡ lock file fix * ⚡ fix Co-authored-by: Michael Kret <michael.k@radency.com> * fix(EmailReadImap Node): Improve handling of network problems (#3406) * ⚡ fix * ⚡ tlsOptions fix * 👕 Fix lint issue * feat(Rename Node): Add regex replace (#2576) * ✨ Add regex replace for Rename node * ⚡ ability to add multiple regex, case insensetivity option, UI imrovements * ⚡ UI update: * ⚡ removed hint * 🔨 UI change, regex under additional options * ⚡ added notice * ⚡ Fix order and set correct default value * 👕 Fix lint issue Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> * feat(Elasticsearch Node): Add 'Source Excludes' and 'Source Includes' options on 'Document: getAll' operation (#3660) * Added 'Source Excludes' and 'Source Includes' options on 'document: getAll' operation * Updated credentials to use new system Co-authored-by: mp <miguel@mconf.com> Co-authored-by: miguel-mconf <107938570+miguel-mconf@users.noreply.github.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * feat(AWS DynamoDB Node): Improve error handling (#3661) Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * fix(Google Drive Node): Process all input items with List operation (#3525) * Fix: process all input items in GDrive list * ⚡ linter fixes * ⚡ added versioning * ⚡ fix option naming * ⚡ removed option for choosing list operation behavior * ⚡ Improvement Co-authored-by: Yann Jouanique <yann.jouanique@gmail.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat: Updated multiple credentials with tests and allow to be used on HTTP Request Node (#3670) * Notion cred updated * Airtable new cred * revamped twilio cred * urlscanlo revamp cred * Wordpress revamp cred with testing * SendGrid cred revamped * 🐛 Fix imports * 🐛 Fixes imports in urlscanio * Fix airtable cred injection * Fixes notion request, changes way of cred injection * Change auth type from method to generic * Fix minor issues * Fix lint issue Co-authored-by: Omar Ajoue <krynble@gmail.com> * refactor: Add `action` to all operations on all nodes (#3655) * 👕 Add `action` to `INodePropertyOptions` * 👕 Apply `node-param-operation-option-without-action` * ✏️ Fix add/remove phrasing * ✏️ Fix email template phrasing * ✏️ Fix add/remove phrasing * ✏️ Fix custom fields phrasing * ✏️ Fix job report phrasing * ✏️ Fix query phrasing * ✏️ Various phrasing fixes * ✏️ Fix final phrasings * ✏️ Remove `conversation` * ✏️ Fix plural * refactor(editor): Create N8nCheckbox Vue component (#3678) * ✨ Implementing N8nCheckbox Vue component * ✨ Added checkbox support to N8nFormInput component * 👌 Updating n8n-checkbox component so it supports indeterminate state and input event * 💄 Adding the `labelSize` property to the `N8nCheckbox` component * feat: Add item information to more node errors (#3681) * ⚡ Add `itemIndex` to node-thrown errors * ⚡ Add some missing item indexes * fix(editor): Fix error after multiple executions (#3697) * 📌 Pin `vue-fragment` to 1.5.1 * 📦 Update `package-lock.json` * ⬆️ Update package-lock.json file * 🔖 Release n8n-workflow@0.108.0 * ⬆️ Set n8n-workflow@0.108.0 on n8n-core * 🔖 Release n8n-core@0.126.0 * ⬆️ Set n8n-core@0.126.0 and n8n-workflow@0.108.0 on n8n-node-dev * 🔖 Release n8n-node-dev@0.65.0 * ⬆️ Set n8n-core@0.126.0 and n8n-workflow@0.108.0 on n8n-nodes-base * 🔖 Release n8n-nodes-base@0.184.0 * 🔖 Release n8n-design-system@0.26.0 * ⬆️ Set n8n-design-system@0.26.0 and n8n-workflow@0.108.0 on n8n-editor-ui * 🔖 Release n8n-editor-ui@0.152.0 * ⬆️ Set n8n-core@0.126.0, n8n-editor-ui@0.152.0, n8n-nodes-base@0.184.0 and n8n-workflow@0.108.0 on n8n * 🔖 Release n8n@0.186.0 * 👕 Fix lint issue * 📚 Update CHANGELOG.md with version 0.186.0 * 🔖 Update main package.json to 0.186.0 * fix(Airtable Node): Fix authentication issue (#3709) * 🔖 Release n8n-nodes-base@0.184.1 * ⬆️ n8n-nodes-base@0.186.1 on n8n * 🔖 Release n8n@0.186.1 * 📚 Update CHANGELOG.md with version 0.186.1 * 🔖 Update main package.json to 0.186.1 * 🔥 Remove access token credential from package.json * fix: Fix broken links in nodes (#3716) * test: Mock mailer service (#3711) * 🧪 Mock mailer service * 🔥 Remove unneeded imports * ⚡ Improvements * ⚡ Remove array from version property * 🔥 Remove console.log() * fix(editor): Hide 'Execute previous node' button in readonly mode (#3714) * ⚡ Also hide button subtext in readonly mode (#3718) * feat(Google Drive Node): Add move to trash support (#3693) * feat(Google Drive Node): Add move to trash support * ⚡ Improvements Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Shopify Node): Add OAuth support (#3389) * ⚡ wip * ⚡ Add includeAccessTokenInHeader option to OAuth2 * 🔨 fixed build error, fixed trigger node when using token auth * 🔨 fixed trigger when using oauth2 * 🔨 changed default auth method to access token * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Rename includeAccessTokenInHeader to keyToIncludeInAccessTokenHeader * ⚡ Assign values to only header property * 🔥 Remove unreachable code * ⚡ Add keyToIncludeInAccessTokenHeader when isN8nRequest * ⚡ Add CC grant type when isN8nRequest Co-authored-by: Ricardo Espinoza <ricardo@n8n.io> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * feat: Add more credentials tests (#3668) * ✨ Add injection to notion, Add test to notion in cred * 🔥 Remove unuse method * 🎨 Move testing from node file to cred file * ✨ Add injection and testing in facebook graph * Add cred injec with testing * Add Cred injection and cred test * Add cred injection, and cred testing for typeform, fix issue in clickup * Add cred injection, move testing inside creds * Add cred injection and cred testing to SendGrid * Add cred injection and cred testing to woocommerce * Add cred injection, add cred test to gitlab * 🔥 Fix duplicated imports in Mautic cred * 🔥 removed unused credentials testing in node * Add cred injection, cred testing, handles slash trailing for Grafana node * Add cred injection, cred testing to shopify * Add cred injection , add cred testing to stripe * changed cred injection, add testing to cred for mattermost * add cred injection and testing for dropbox * Add cred injection, cred testing to webflow * ✨ Add cred injection and cred test to nocodb * ✨ Add cred injection, cred testing to mailchimp * 🐛 fix a bug In credentials testing * ✨ Add cred injection, cred testing to sms77 * ✨ Add cred injection, cred testing to ActiveCampaign * Add cred injection, cred testing to TheHive * ✨ Add cred injection, add cred testing to ApiTemplateio * ✨ Add cred injection, add cred testing for zoom * ✨ Add cred injection, cred testing to rocketchat * ✨ Add cred injection, add cred test to getResponse * 🔥 Remove useless authentcate creds and testing from facebookGraphApp * 🔥 Remove useless imports in FacebookGrappApp credentials file * 🔥 Removed useless imports and if statement * 🐛 Add version to header when testing cred Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> * fix(Baserow Node): Fix issue that table names are not getting pulled in new version (#3721) * refactor: Move OAuth2 endpoints to OAuth2 controller (#3450) * Move oauth2 endpoints to oauth2 controller * Remove old oauth2-credential auth endpoint from server.ts * Move OAuth2 callback endpoint to controller * Fix tests and eslint issues * Fix typo * fix lint issues * update package-lock * Import lodash methods individually * Minimise lint rule disables * Cleanup * rebase * CR * npm package: Remove lodash, use lodash.intersect * fixups * rebase * ⚡ Simplify code Co-authored-by: Ahsan Virani <ahsan.virani@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com> Co-authored-by: Ricardo Espinoza <ricardo@n8n.io> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Milorad FIlipović <miloradfilipovic19@gmail.com> Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com> Co-authored-by: pemontto <pemontto@gmail.com> Co-authored-by: Cornelius Suermann <cornelius@n8n.io> Co-authored-by: Zapfmeister <zapfmeister@gmail.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: agobrech <ael.gobrecht@gmail.com> Co-authored-by: pemontto <939704+pemontto@users.noreply.github.com> Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Co-authored-by: Yann Jouanique <yann.jouanique@gmail.com> Co-authored-by: Yann Jouanique <yann.jouanique@oneacrefund.org> Co-authored-by: Cyril Gobrecht <cyril.gobrecht@gmail.com> Co-authored-by: Nicholas Penree <nick@penree.com> Co-authored-by: Taha Sönmez <35905778+tahasonmez@users.noreply.github.com> Co-authored-by: Jan Thiel <JanThiel@users.noreply.github.com> Co-authored-by: h4ux <alon@h4ux.com> Co-authored-by: Bryce Sheehan <bryce.sheehan@gmail.com> Co-authored-by: mp <miguel@mconf.com> Co-authored-by: miguel-mconf <107938570+miguel-mconf@users.noreply.github.com> Co-authored-by: Olivier Aygalenq <56312812+oaygalenq@users.noreply.github.com>

ahsanv force-pushed the n8n-3815-telemetry-tweaks branch 2 times, most recently from 3696162 to 77d3678 Compare June 16, 2022 16:21

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 16, 2022

ahsanv force-pushed the n8n-3815-telemetry-tweaks branch 4 times, most recently from 5c4e9ab to 3797c73 Compare June 24, 2022 14:20

ahsanv marked this pull request as ready for review June 30, 2022 13:30

ahsanv force-pushed the n8n-3815-telemetry-tweaks branch 2 times, most recently from c0a0a8d to e4d828c Compare June 30, 2022 14:57

ahsanv requested a review from mutdmour June 30, 2022 15:16

ahsanv force-pushed the n8n-3815-telemetry-tweaks branch from e4d828c to d6aafc8 Compare July 1, 2022 08:13

mutdmour reviewed Jul 4, 2022

View reviewed changes

ahsanv added 15 commits July 5, 2022 16:23

Init unit tests for telemetry

a853723

Update telemetry tests

a289d44

Test Workflow execution errored event

771ea58

Add new tracking logic in pulse

5bbcbb3

cleanup

43b2f51

interfaces

f13ee43

Add event_version for Workflow execution count event

50586c5

add version_cli in all events

3801e67

add user saved credentials event

41d3940

update manual wf exec finished, fixes

03581de

improve typings, lint

3770914

add node_graph_string in User clicked execute workflow button event

d78a776

add User set node operation or mode event

106aa49

Add instance started event in FE

28c5131

Add User clicked retry execution button event

7b8b477

ahsanv added 8 commits July 5, 2022 16:23

add User stopped workflow execution wvent

cb0349b

add error message in saved credential event

247f419

update stop execution event

b10bc7d

add execution preflight event

11776e8

Remove instance started even tfrom FE, add session started to FE,BE

3d4acec

improve typing

5328aae

remove node_graph as property from all events

a2fb2f6

move back from default export

e2de296

ahsanv force-pushed the n8n-3815-telemetry-tweaks branch from 8aa1195 to e2de296 Compare July 5, 2022 14:23

ahsanv added 6 commits July 5, 2022 16:36

move psl npm package to cli package

cf43df4

cr

193cfce

update webhook node domain logic

c6b84eb

fix is_valid for User saved credentials event

7fe05c7

fix Expression Editor variable selector event

5ccb99d

add caused_by_credential in preflight event

a4b225e

ahsanv requested a review from mutdmour July 6, 2022 10:33

mutdmour reviewed Jul 7, 2022

View reviewed changes

ahsanv added 2 commits July 7, 2022 21:03

undo webhook_domain

a485832

change node_type to full type

a0f5247

mutdmour approved these changes Jul 8, 2022

View reviewed changes

add webhook_domain property in manual execution event (#3680)

c219217

* add webhook_domain property in manual execution event * lint fix

janober merged commit 6b2db8e into master Jul 10, 2022

janober deleted the n8n-3815-telemetry-tweaks branch July 10, 2022 06:53

janober added the Upcoming Release Will be part of the upcoming release label Jul 10, 2022

janober removed the Upcoming Release Will be part of the upcoming release label Jul 13, 2022

snyk-bot mentioned this pull request Aug 10, 2022

[Snyk] Upgrade n8n-workflow from 0.105.0 to 0.108.0 skreuter/n8n#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Telemetry updates #3529

✨ Telemetry updates #3529

ahsanv commented Jun 16, 2022

mutdmour Jul 4, 2022 •

edited

Loading

ahsanv Jul 5, 2022

mutdmour Jul 4, 2022

mutdmour Jul 4, 2022

ahsanv Jul 5, 2022 •

edited

Loading

mutdmour Jul 7, 2022

mutdmour Jul 4, 2022

mutdmour Jul 4, 2022

mutdmour Jul 7, 2022

janober commented Jul 10, 2022

janober commented Jul 13, 2022

		...properties,
		version_cli: this.store && this.store.getters.versionCli,

	if(eventData.variable.startsWith('Object.keys')) {
	if (eventData.variable.startsWith('Object.keys')) {

✨ Telemetry updates #3529

✨ Telemetry updates #3529

Conversation

ahsanv commented Jun 16, 2022

mutdmour Jul 4, 2022 • edited Loading

Choose a reason for hiding this comment

ahsanv Jul 5, 2022

Choose a reason for hiding this comment

mutdmour Jul 4, 2022

Choose a reason for hiding this comment

mutdmour Jul 4, 2022

Choose a reason for hiding this comment

ahsanv Jul 5, 2022 • edited Loading

Choose a reason for hiding this comment

mutdmour Jul 7, 2022

Choose a reason for hiding this comment

mutdmour Jul 4, 2022

Choose a reason for hiding this comment

mutdmour Jul 4, 2022

Choose a reason for hiding this comment

mutdmour Jul 7, 2022

Choose a reason for hiding this comment

janober commented Jul 10, 2022

janober commented Jul 13, 2022

mutdmour Jul 4, 2022 •

edited

Loading

ahsanv Jul 5, 2022 •

edited

Loading