-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): implement executions preview via the new executions tab in node view #4311
Merged
MiloradFilipovic
merged 87 commits into
master
from
feature/workflows-executions-navigation-redesign
Oct 26, 2022
Merged
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
403d494
✨ Added main header tabs with current workflow execution count
MiloradFilipovic b7bbb82
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 9bbec22
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 8aef947
feat(editor): header tab navigation (no-changelog) (#4244)
MiloradFilipovic 9c9a223
✨ Implemented empty states for executions view
MiloradFilipovic 411f2cf
⚡ Adding execute button shake flag to the store so it doesn't mess up…
MiloradFilipovic 75c8404
💄 Started adding new styles to execution sidebar
MiloradFilipovic 071f4f2
💄 Adding hover style for execution list
MiloradFilipovic 909a43d
⚡ Added ExecutionsCard component and added executions helper mixin
MiloradFilipovic 7a3a6dc
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 7f32971
✔️ Fixing leftover conflict
MiloradFilipovic 179721d
✔️ One more conflict
MiloradFilipovic cd27392
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic c9d4e89
✨ Implemented retry execution menu and manual execution icon. Other m…
MiloradFilipovic 0fa95f7
✨ Implemented executions filtering
MiloradFilipovic 7ba377f
💄 Updating running executions details in preview
MiloradFilipovic de6f09d
⚡ Added info accordion to executions sidebar
MiloradFilipovic 974fbc7
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 1bd88b9
✨ Implemented auto-refresh for executions sidebar
MiloradFilipovic 6416a5a
💄 Adding running execution landing page, minor fixes
MiloradFilipovic 2aef6b7
💄 General refactoring
MiloradFilipovic 6dabdc3
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 34fcbc3
✔️ Adding leftover conflict changes
MiloradFilipovic 6980511
✔️ Updating `InfoTip` component test snapshots
MiloradFilipovic e105bbb
✔️ Fixing linting error
MiloradFilipovic 1ad67cc
✔️ Fixing lint errors in vuex store module
MiloradFilipovic 7547f11
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic fc8c00e
👌 Started addressing review feedback
MiloradFilipovic 8f4b306
⚡ Updating executions preview behaviour when filters are applied
MiloradFilipovic 26a88cf
🐛 Fixing a bug where nodes and connections disappear if something is …
MiloradFilipovic bdef1d7
🐛 Fixing pasting in executions view and wrong workflow activator state
MiloradFilipovic f4333d5
⚡ Improved workflow switching and navigation, updated error message w…
MiloradFilipovic a1e76d6
⚡ Some more navigation updates
MiloradFilipovic 9eeb7f2
💄 Fixing tab centering, execution filter button layout, added auto-re…
MiloradFilipovic f6ecb40
🐛 Fixing a bug when saving workflow using save button
MiloradFilipovic f0f3171
💄 Addressing design feedback, added delete execution button
MiloradFilipovic d980149
⚡ Moving main execution logic to the root executions view
MiloradFilipovic 2b1aa9a
⚡ Implemented execution delete function
MiloradFilipovic 892f3a6
⚡ Updating how switching tabs for new unsaved workflows work
MiloradFilipovic 1fec270
⚡ Remembering active execution when switching tabs
MiloradFilipovic dab053e
💄 Addressing design feedback regarding info accordion
MiloradFilipovic d6eff29
💄 Updating execution card styling
MiloradFilipovic dbc2162
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 6c15615
⚡ Resetting executions when creating new workflow
MiloradFilipovic 557a3ba
Fixing lint error
MiloradFilipovic ace9511
⚡ Hiding executions preview is active execution is not in the results…
MiloradFilipovic 0026cf4
⚡ Fixing navigation to and from templates and executions
MiloradFilipovic 95daf4d
⚡ Implemented execution lazy loading and added new background to exec…
MiloradFilipovic a7a1ee8
💄 Disabling import when on executions tab
MiloradFilipovic 0125b7e
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic d5ba9ae
⚡ Handling opening executions from different workflow
MiloradFilipovic 5c3fc27
⚡ Updating active execution on route change
MiloradFilipovic 38ee173
⚡ Updating execution tab detection
MiloradFilipovic dd8be42
⚡ Simplifying and updating navigation. Adding new route for new workf…
MiloradFilipovic 3106b59
⚡ Updating workflow saving logic to work with new routes
MiloradFilipovic 6c9005d
🐛 Fixing a bug when returning to executions from different workflow
MiloradFilipovic f4bc3a0
💄 Updating executions info accordion and node details view modal in e…
MiloradFilipovic 8e16680
💄 Updating workflow activated modal to point to new executions view
MiloradFilipovic 8981872
⚡ Implemented opening new executions view from execution modal
MiloradFilipovic 0f1b66d
⚡ Handling jsplumb init errors, updating unknown executions style
MiloradFilipovic ec0d654
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic bee40e2
⚡ Updating main sidebar after syncing branch
MiloradFilipovic 54a8672
⚡ Opening new trigger menu from executions view
MiloradFilipovic ccbf121
💄 Updating sidebar resize behaviour
MiloradFilipovic d024f85
✔️ Fixing lint errors
MiloradFilipovic 91f9a33
⚡ Loading executions when mounting executions view
MiloradFilipovic 7462d18
⚡ Resetting execution data when creating a new workflow
MiloradFilipovic 394bd8c
💄 Minor wording updates
MiloradFilipovic 8fe9739
⚡ Not reloading node view when new workflows are saved
MiloradFilipovic 7500c42
Removing leftover console log
MiloradFilipovic 035b83f
🐛 Fixed a bug with save dialog not appearing when leaving executions tab
MiloradFilipovic 4f3514c
⚡ Updating manual execution settings detection in info accordion
MiloradFilipovic 6616da0
💄 Addressing UI issues found during bug bash
MiloradFilipovic 59ff521
Fixing workflow saving logic
MiloradFilipovic 8ef85d9
⚡ Preventing navigation if clicked tab is already opened
MiloradFilipovic 1437dfe
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic 95651c3
⚡ Updating lazy loading behaviour
MiloradFilipovic 45687d0
⚡ Updating delete executions flow
MiloradFilipovic 7193900
⚡ Added retry executions button to the execution preview
MiloradFilipovic 6713a1f
⚡ Adding empty execution state, updating trigger detection logic, rem…
MiloradFilipovic 5691f34
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic b8e1768
💄 Cosmetic code improvements
MiloradFilipovic 4ade4fb
Trying the performance fix for nodeBase
MiloradFilipovic 0696fe6
Removing the `NodeBase`fix
MiloradFilipovic 3a7acb0
🐛 Fixing a bug when saving the current workflow
MiloradFilipovic 40b9e9a
Merge branch 'master' into feature/workflows-executions-navigation-re…
MiloradFilipovic c6f9c55
👌 Addressing code review feedback
MiloradFilipovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...ages/design-system/src/components/N8nInfoTip/__tests__/__snapshots__/InfoTip.spec.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
// Vitest Snapshot v1 | ||
|
||
exports[`N8nInfoTip > should render correctly as note 1`] = `"<div class=\\"n8n-info-tip _info_3egb8_33 _note_3egb8_16 _base_3egb8_1 _bold_3egb8_12\\"><span class=\\"_iconText_3egb8_28\\"><span class=\\"n8n-icon n8n-text _compact_odhsl_34 _size-medium_odhsl_19 _regular_odhsl_5\\"></span><span>Need help doing something?<a href=\\"/docs\\" target=\\"_blank\\">Open docs</a></span></span></div>"`; | ||
exports[`N8nInfoTip > should render correctly as note 1`] = `"<div class=\\"n8n-info-tip _info_3egb8_33 _note_3egb8_16 _base_3egb8_1 _bold_3egb8_12\\"><span class=\\"_iconText_3egb8_28\\"><span class=\\"n8n-icon n8n-text _compact_e4k11_34 _size-medium_e4k11_19 _regular_e4k11_5\\"></span><span>Need help doing something?<a href=\\"/docs\\" target=\\"_blank\\">Open docs</a></span></span></div>"`; | ||
|
||
exports[`N8nInfoTip > should render correctly as tooltip 1`] = ` | ||
"<div class=\\"n8n-info-tip _info_3egb8_33 _tooltip_3egb8_23 _base_3egb8_1 _bold_3egb8_12\\"> | ||
<n8n-tooltip-stub justifybuttons=\\"flex-end\\" buttons=\\"\\" placement=\\"top\\"><span class=\\"_iconText_3egb8_28\\"><span class=\\"n8n-icon n8n-text _compact_odhsl_34 _size-medium_odhsl_19 _regular_odhsl_5\\"></span></span><span>Need help doing something?<a href=\\"/docs\\" target=\\"_blank\\">Open docs</a></span></n8n-tooltip-stub> | ||
<n8n-tooltip-stub justifybuttons=\\"flex-end\\" buttons=\\"\\" placement=\\"top\\"><span class=\\"_iconText_3egb8_28\\"><span class=\\"n8n-icon n8n-text _compact_e4k11_34 _size-medium_e4k11_19 _regular_e4k11_5\\"></span></span><span>Need help doing something?<a href=\\"/docs\\" target=\\"_blank\\">Open docs</a></span></n8n-tooltip-stub> | ||
</div>" | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed? could this have memory or perf implications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure it's not optimal but it's the only way to keep the main
NodeView
active, so it's not reloading every time we switch tabs. I guess this is the UX we are after in this feature.include
andmax
parameters will limit router view so it only caches one instance ofNodeView
and not other components that render in that slot.