n8n-io · netroy · Nov 8, 2022 · Nov 4, 2022 · Nov 8, 2022 · Nov 8, 2022
diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js
@@ -283,11 +283,6 @@ const config = (module.exports = {
 		 */
 		'@typescript-eslint/no-unused-expressions': 'error',
 
-		/**
-		 * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unused-vars.md
-		 */
-		'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '_' }],
-
 		/**
 		 * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.md
 		 */
@@ -367,7 +362,16 @@ const config = (module.exports = {
 		 *
 		 * Disabled because eslint-plugin-diff fails to catch it. TODO: Revisit.
 		 */
-		'@typescript-eslint/no-unused-vars': 'warn',
+		'no-unused-vars': 'off',
+		'@typescript-eslint/no-unused-vars': [
+			'error',
+			{
+				argsIgnorePattern: '^_',
+				destructuredArrayIgnorePattern: '^_',
+				varsIgnorePattern: '^_',
+				ignoreRestSiblings: true,
+			},
+		],
 
 		// ----------------------------------
 		//              import

diff --git a/packages/cli/src/credentials/credentials.service.ee.ts b/packages/cli/src/credentials/credentials.service.ee.ts
@@ -1,7 +1,7 @@
 /* eslint-disable import/no-cycle */
 /* eslint-disable no-param-reassign */
-import { DeleteResult, EntityManager, FindManyOptions, In, Not } from 'typeorm';
-import { Db, ICredentialsDb } from '..';
+import { DeleteResult, EntityManager, In, Not } from 'typeorm';
+import { Db } from '..';
 import { RoleService } from '../role/role.service';
 import { CredentialsService } from './credentials.service';
 

diff --git a/packages/cli/src/workflows/workflows.services.ts b/packages/cli/src/workflows/workflows.services.ts
@@ -52,6 +52,7 @@ export class WorkflowsService {
 		workflow: WorkflowEntity,
 		workflowId: string,
 		tags?: string[],
+		// eslint-disable-next-line @typescript-eslint/no-unused-vars
 		forceSave?: boolean,
 	): Promise<WorkflowEntity> {
 		const shared = await Db.collections.SharedWorkflow.findOne({

diff --git a/packages/nodes-base/.eslintrc.js b/packages/nodes-base/.eslintrc.js
@@ -9,7 +9,7 @@ module.exports = {
 
 	rules: {
 		// TODO: remove all the following rules
-		'eqeqeq': 'off',
+		eqeqeq: 'off',
 		'id-denylist': 'off',
 		'import/extensions': 'off',
 		'import/order': 'off',
@@ -25,10 +25,7 @@ module.exports = {
 		'@typescript-eslint/dot-notation': 'off',
 		'@typescript-eslint/lines-between-class-members': 'off',
 		'@typescript-eslint/member-delimiter-style': 'off',
-		'@typescript-eslint/naming-convention': [
-			'error',
-			{ selector: 'memberLike', format: null },
-		],
+		'@typescript-eslint/naming-convention': ['error', { selector: 'memberLike', format: null }],
 		'@typescript-eslint/no-duplicate-imports': 'off',
 		'@typescript-eslint/no-empty-interface': 'off',
 		'@typescript-eslint/no-explicit-any': 'off',
@@ -49,7 +46,6 @@ module.exports = {
 		'@typescript-eslint/no-unsafe-member-access': 'off',
 		'@typescript-eslint/no-unsafe-return': 'off',
 		'@typescript-eslint/no-unused-expressions': 'off',
-		'@typescript-eslint/no-unused-vars': 'off',
 		'@typescript-eslint/no-use-before-define': 'off',
 		'@typescript-eslint/no-var-requires': 'off',
 		'@typescript-eslint/prefer-nullish-coalescing': 'off',
@@ -171,4 +167,4 @@ module.exports = {
 			},
 		},
 	],
- };
+};
diff --git a/packages/nodes-base/credentials/Aws.credentials.ts b/packages/nodes-base/credentials/Aws.credentials.ts
@@ -1,5 +1,5 @@
 import { Request, sign } from 'aws4';
-import { ICredentialTestRequest, IHttpRequestMethods } from 'n8n-workflow';
+import { ICredentialTestRequest } from 'n8n-workflow';
 import {
 	ICredentialDataDecryptedObject,
 	ICredentialType,
@@ -369,9 +369,3 @@ export class Aws implements ICredentialType {
 		},
 	};
 }
-
-function queryToString(params: IDataObject) {
-	return Object.keys(params)
-		.map((key) => key + '=' + params[key])
-		.join('&');
-}
diff --git a/packages/nodes-base/credentials/DropboxApi.credentials.ts b/packages/nodes-base/credentials/DropboxApi.credentials.ts
@@ -1,6 +1,5 @@
 import {
 	IAuthenticateGeneric,
-	ICredentialTestFunction,
 	ICredentialTestRequest,
 	ICredentialType,
 	INodeProperties,

diff --git a/packages/nodes-base/credentials/MailchimpApi.credentials.ts b/packages/nodes-base/credentials/MailchimpApi.credentials.ts
@@ -1,6 +1,5 @@
 import {
 	IAuthenticateGeneric,
-	ICredentialTestFunctions,
 	ICredentialTestRequest,
 	ICredentialType,
 	INodeProperties,

diff --git a/packages/nodes-base/credentials/MattermostApi.credentials.ts b/packages/nodes-base/credentials/MattermostApi.credentials.ts
@@ -1,9 +1,7 @@
 import {
 	IAuthenticateGeneric,
-	ICredentialDataDecryptedObject,
 	ICredentialTestRequest,
 	ICredentialType,
-	IHttpRequestOptions,
 	INodeProperties,
 } from 'n8n-workflow';
 

diff --git a/packages/nodes-base/credentials/MetabaseApi.credentials.ts b/packages/nodes-base/credentials/MetabaseApi.credentials.ts
@@ -4,7 +4,6 @@ import {
 	ICredentialTestRequest,
 	ICredentialType,
 	IHttpRequestHelper,
-	IHttpRequestOptions,
 	INodeProperties,
 } from 'n8n-workflow';
 

diff --git a/packages/nodes-base/credentials/NocoDb.credentials.ts b/packages/nodes-base/credentials/NocoDb.credentials.ts
@@ -1,9 +1,4 @@
-import {
-	IAuthenticateGeneric,
-	ICredentialTestRequest,
-	ICredentialType,
-	INodeProperties,
-} from 'n8n-workflow';
+import { IAuthenticateGeneric, ICredentialType, INodeProperties } from 'n8n-workflow';
 
 export class NocoDb implements ICredentialType {
 	name = 'nocoDb';

diff --git a/packages/nodes-base/credentials/NocoDbApiToken.credentials.ts b/packages/nodes-base/credentials/NocoDbApiToken.credentials.ts
@@ -1,9 +1,4 @@
-import {
-	IAuthenticateGeneric,
-	ICredentialTestRequest,
-	ICredentialType,
-	INodeProperties,
-} from 'n8n-workflow';
+import { IAuthenticateGeneric, ICredentialType, INodeProperties } from 'n8n-workflow';
 
 export class NocoDbApiToken implements ICredentialType {
 	name = 'nocoDbApiToken';

diff --git a/packages/nodes-base/credentials/ShopifyApi.credentials.ts b/packages/nodes-base/credentials/ShopifyApi.credentials.ts
@@ -1,6 +1,5 @@
 import { BINARY_ENCODING } from 'n8n-core';
 import {
-	IAuthenticateGeneric,
 	ICredentialDataDecryptedObject,
 	ICredentialTestRequest,
 	ICredentialType,

diff --git a/packages/nodes-base/credentials/TheHiveApi.credentials.ts b/packages/nodes-base/credentials/TheHiveApi.credentials.ts
@@ -1,5 +1,4 @@
 import {
-	IAuthenticate,
 	IAuthenticateGeneric,
 	ICredentialTestRequest,
 	ICredentialType,

diff --git a/packages/nodes-base/credentials/TwilioApi.credentials.ts b/packages/nodes-base/credentials/TwilioApi.credentials.ts
@@ -1,11 +1,4 @@
-import {
-	IAuthenticateGeneric,
-	ICredentialDataDecryptedObject,
-	ICredentialTestRequest,
-	ICredentialType,
-	IHttpRequestOptions,
-	INodeProperties,
-} from 'n8n-workflow';
+import { IAuthenticateGeneric, ICredentialType, INodeProperties } from 'n8n-workflow';
 
 export class TwilioApi implements ICredentialType {
 	name = 'twilioApi';

diff --git a/packages/nodes-base/credentials/VenafiTlsProtectCloudApi.credentials.ts b/packages/nodes-base/credentials/VenafiTlsProtectCloudApi.credentials.ts
@@ -1,9 +1,7 @@
 import {
 	IAuthenticateGeneric,
-	ICredentialDataDecryptedObject,
 	ICredentialTestRequest,
 	ICredentialType,
-	IHttpRequestOptions,
 	NodePropertyTypes,
 } from 'n8n-workflow';
 

diff --git a/packages/nodes-base/credentials/WhatsAppApi.credentials.ts b/packages/nodes-base/credentials/WhatsAppApi.credentials.ts
@@ -1,11 +1,8 @@
 import {
 	IAuthenticateGeneric,
-	ICredentialDataDecryptedObject,
 	ICredentialTestRequest,
 	ICredentialType,
-	IHttpRequestOptions,
 	INodeProperties,
-	NodePropertyTypes,
 } from 'n8n-workflow';
 
 export class WhatsAppApi implements ICredentialType {

diff --git a/packages/nodes-base/nodes/ActiveCampaign/GenericFunctions.ts b/packages/nodes-base/nodes/ActiveCampaign/GenericFunctions.ts
@@ -1,12 +1,6 @@
 import { IExecuteFunctions, IHookFunctions } from 'n8n-core';
 
-import {
-	IDataObject,
-	ILoadOptionsFunctions,
-	INodeProperties,
-	NodeApiError,
-	NodeOperationError,
-} from 'n8n-workflow';
+import { IDataObject, ILoadOptionsFunctions, INodeProperties, NodeApiError } from 'n8n-workflow';
 
 import { OptionsWithUri } from 'request';
 

diff --git a/packages/nodes-base/nodes/AcuityScheduling/GenericFunctions.ts b/packages/nodes-base/nodes/AcuityScheduling/GenericFunctions.ts
@@ -6,7 +6,7 @@ import {
 	ILoadOptionsFunctions,
 	IWebhookFunctions,
 } from 'n8n-core';
-import { IDataObject, NodeApiError, NodeOperationError } from 'n8n-workflow';
+import { IDataObject, NodeApiError } from 'n8n-workflow';
 
 export async function acuitySchedulingApiRequest(
 	this:
@@ -21,7 +21,7 @@ export async function acuitySchedulingApiRequest(
 	body: any = {},
 	qs: IDataObject = {},
 	uri?: string,
-	option: IDataObject = {},
+	_option: IDataObject = {},
 	// tslint:disable-next-line:no-any
 ): Promise<any> {
 	const authenticationMethod = this.getNodeParameter('authentication', 0);

diff --git a/packages/nodes-base/nodes/Adalo/Adalo.node.ts b/packages/nodes-base/nodes/Adalo/Adalo.node.ts
@@ -2,8 +2,6 @@ import {
 	IDataObject,
 	IExecuteSingleFunctions,
 	IHttpRequestOptions,
-	IN8nHttpFullResponse,
-	INodeExecutionData,
 	INodeType,
 	INodeTypeDescription,
 } from 'n8n-workflow';

diff --git a/packages/nodes-base/nodes/Affinity/GenericFunctions.ts b/packages/nodes-base/nodes/Affinity/GenericFunctions.ts
@@ -2,13 +2,7 @@ import { OptionsWithUri } from 'request';
 
 import { BINARY_ENCODING, IExecuteFunctions, ILoadOptionsFunctions } from 'n8n-core';
 
-import {
-	IDataObject,
-	IHookFunctions,
-	IWebhookFunctions,
-	NodeApiError,
-	NodeOperationError,
-} from 'n8n-workflow';
+import { IDataObject, IHookFunctions, IWebhookFunctions, NodeApiError } from 'n8n-workflow';
 
 export async function affinityApiRequest(
 	this: IExecuteFunctions | IWebhookFunctions | IHookFunctions | ILoadOptionsFunctions,

diff --git a/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts b/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts
@@ -103,7 +103,7 @@ export async function agileCrmApiRequestUpdate(
 	endpoint?: string,
 	// tslint:disable-next-line:no-any
 	body: any = {},
-	query: IDataObject = {},
+	_query: IDataObject = {},
 	uri?: string,
 	// tslint:disable-next-line:no-any
 ): Promise<any> {

diff --git a/packages/nodes-base/nodes/Airtable/Airtable.node.ts b/packages/nodes-base/nodes/Airtable/Airtable.node.ts
@@ -2,27 +2,14 @@ import { IExecuteFunctions } from 'n8n-core';
 
 import {
 	IDataObject,
-	ILoadOptionsFunctions,
 	INodeExecutionData,
-	INodeListSearchResult,
 	INodeType,
 	INodeTypeDescription,
 	NodeOperationError,
 } from 'n8n-workflow';
 
 import { apiRequest, apiRequestAllItems, downloadRecordAttachments } from './GenericFunctions';
 
-interface AirtableBase {
-	id: string;
-	name: string;
-}
-
-interface AirtableTable {
-	id: string;
-	name: string;
-	description: string;
-}
-
 export class Airtable implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'Airtable',

diff --git a/packages/nodes-base/nodes/Airtable/GenericFunctions.ts b/packages/nodes-base/nodes/Airtable/GenericFunctions.ts
@@ -36,8 +36,6 @@ export async function apiRequest(
 	option: IDataObject = {},
 	// tslint:disable-next-line:no-any
 ): Promise<any> {
-	const credentials = await this.getCredentials('airtableApi');
-
 	query = query || {};
 
 	// For some reason for some endpoints the bearer auth does not work

diff --git a/packages/nodes-base/nodes/Autopilot/GenericFunctions.ts b/packages/nodes-base/nodes/Autopilot/GenericFunctions.ts
@@ -12,7 +12,7 @@ export async function autopilotApiRequest(
 	body: any = {},
 	query: IDataObject = {},
 	uri?: string,
-	option: IDataObject = {},
+	_option: IDataObject = {},
 	// tslint:disable-next-line:no-any
 ): Promise<any> {
 	const credentials = (await this.getCredentials('autopilotApi')) as IDataObject;

diff --git a/packages/nodes-base/nodes/Aws/AwsLambda.node.ts b/packages/nodes-base/nodes/Aws/AwsLambda.node.ts
@@ -8,7 +8,6 @@ import {
 	INodeTypeDescription,
 	JsonObject,
 	NodeApiError,
-	NodeOperationError,
 } from 'n8n-workflow';
 
 import { awsApiRequestREST } from './GenericFunctions';
@@ -191,10 +190,10 @@ export class AwsLambda implements INodeType {
 				);
 
 				if (responseData !== null && responseData?.errorMessage !== undefined) {
-					let errorMessage = responseData.errorMessage;
+					let _errorMessage = responseData.errorMessage;
 
 					if (responseData.stackTrace) {
-						errorMessage += `\n\nStack trace:\n${responseData.stackTrace}`;
+						_errorMessage += `\n\nStack trace:\n${responseData.stackTrace}`;
 					}
 
 					throw new NodeApiError(this.getNode(), responseData);

diff --git a/packages/nodes-base/nodes/Aws/AwsSns.node.ts b/packages/nodes-base/nodes/Aws/AwsSns.node.ts
@@ -6,8 +6,6 @@ import {
 	INodePropertyOptions,
 	INodeType,
 	INodeTypeDescription,
-	NodeApiError,
-	NodeOperationError,
 } from 'n8n-workflow';
 
 import { awsApiRequestSOAP } from './GenericFunctions';

diff --git a/packages/nodes-base/nodes/Aws/Comprehend/GenericFunctions.ts b/packages/nodes-base/nodes/Aws/Comprehend/GenericFunctions.ts
@@ -1,9 +1,3 @@
-import { URL } from 'url';
-
-import { Request, sign } from 'aws4';
-
-import { OptionsWithUri } from 'request';
-
 import { parseString } from 'xml2js';
 
 import {
@@ -13,7 +7,7 @@ import {
 	IWebhookFunctions,
 } from 'n8n-core';
 
-import { ICredentialDataDecryptedObject, IHttpRequestOptions, NodeApiError, NodeOperationError } from 'n8n-workflow';
+import { IHttpRequestOptions, NodeApiError } from 'n8n-workflow';
 
 export async function awsApiRequest(
 	this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions | IWebhookFunctions,

diff --git a/packages/nodes-base/nodes/Aws/DynamoDB/GenericFunctions.ts b/packages/nodes-base/nodes/Aws/DynamoDB/GenericFunctions.ts
@@ -5,13 +5,7 @@ import {
 	IWebhookFunctions,
 } from 'n8n-core';
 
-import {
-	deepCopy,
-	ICredentialDataDecryptedObject,
-	IDataObject,
-	IHttpRequestOptions,
-	INodeExecutionData,
-} from 'n8n-workflow';
+import { deepCopy, IDataObject, IHttpRequestOptions, INodeExecutionData } from 'n8n-workflow';
 
 import { IRequestBody } from './types';