Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Skip interim updates check (no-changelog) #4536

Merged
merged 2 commits into from
Nov 7, 2022
Merged

refactor(core): Skip interim updates check (no-changelog) #4536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7660ca8
:zap: Skip interim updates check
ivov Nov 7, 2022
4231686
:twisted_rightwards_arrows: Merge master
ivov Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/cli/src/workflows/workflows.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ export class WorkflowsService {
);
}

if (!forceSave && workflow.hash !== shared.workflow.hash) {
throw new ResponseHelper.ResponseError(
`Workflow ID ${workflowId} cannot be saved because it was changed by another user.`,
undefined,
400,
);
}
// if (!forceSave && workflow.hash !== shared.workflow.hash) {
// throw new ResponseHelper.ResponseError(
// `Workflow ID ${workflowId} cannot be saved because it was changed by another user.`,
// undefined,
// 400,
// );
// }

// check credentials for old format
await WorkflowHelpers.replaceInvalidCredentials(workflow);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/integration/workflows.controller.ee.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ describe('PATCH /workflows/:id - validate credential permissions to user', () =>
});
});

describe('PATCH /workflows/:id - validate interim updates', () => {
describe.skip('PATCH /workflows/:id - validate interim updates', () => {
it('should block owner updating workflow nodes on interim update by member', async () => {
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
const member = await testDb.createUser({ globalRole: globalMemberRole });
Expand Down