Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate Vue slots to the new syntax #4603

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 14, 2022

This is a needed before we migrate to Vue 3

@linear
Copy link

linear bot commented Nov 14, 2022

N8N-5561

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 14, 2022
@netroy netroy changed the title refactor: migrate Vue slots to the new syntax refactor: Migrate Vue slots to the new syntax Nov 14, 2022
@netroy netroy force-pushed the N8N-5561-vue-slots branch 2 times, most recently from 861e11c to 0fc2db5 Compare November 15, 2022 19:39
@netroy netroy marked this pull request as ready for review November 18, 2022 09:52
@netroy netroy requested a review from alexgrozav November 18, 2022 09:52
need to figure out how to get nested slots working correctly in the new syntax
@netroy netroy force-pushed the N8N-5561-vue-slots branch from 002bf92 to d1d3a96 Compare November 18, 2022 09:54
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested manually as well.

@netroy netroy merged commit 600b285 into master Nov 18, 2022
@netroy netroy deleted the N8N-5561-vue-slots branch November 18, 2022 13:59
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 18, 2022
@janober
Copy link
Member

janober commented Nov 18, 2022

Got released with n8n@0.203.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 18, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 18, 2022
* master:
  fix(editor): Fix missing resource locator component (#4649)
  refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648)
  refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)
  refactor: Migrate Vue slots to the new syntax (#4603)
  refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)
  fix: Make users fakedoor route visible on cloud (#4645)
  📚 Update CHANGELOG.md and main package.json to 0.203.1
MiloradFilipovic added a commit that referenced this pull request Nov 21, 2022
* feature/ad-ldap: (108 commits)
  👕 Fix linting problem
  fix: Workflow activation should not crash if one of the credential is invalid (#4671)
  feat(core): Add license support to n8n (#4566)
  fix: Use the updated slots syntax in ResourceLocator (no-changelog) (#4663)
  fix: Community package uninstall button should show the confirmation modal (no-changelog) (#4668)
  fix: Fix broken n8n-info-tip slots (#4665)
  fix(editor): Table view column limit tooltip (#4655)
  ci: Block execution of `npm install` (no-changelog) (#4662)
  fix(editor): Prevent node-creator tabs from showing when toggled by CanvasAddButton (#4661)
  fix(Schedule Trigger Node): Fixes inconsitent behavior with cron and weekly intervals (#4558)
  fix(core): Fix for unused imports
  fix: Add temporary slot syntax lint exceptions (no-changelog) (#4652)
  fix(editor): Fix missing resource locator component (#4649)
  refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648)
  refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)
  refactor: Migrate Vue slots to the new syntax (#4603)
  refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)
  fix: Make users fakedoor route visible on cloud (#4645)
  📚 Update CHANGELOG.md and main package.json to 0.203.1
  🔖 Release n8n@0.203.1
  ...

# Conflicts:
#	packages/design-system/src/components/N8nFormInput/FormInput.vue
#	packages/design-system/src/components/N8nFormInputs/FormInputs.stories.js
#	packages/design-system/src/components/N8nFormInputs/FormInputs.vue
#	packages/design-system/src/types/form.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants