Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): JSON schema view #4615

Merged
merged 37 commits into from
Dec 6, 2022
Merged

feat(editor): JSON schema view #4615

merged 37 commits into from
Dec 6, 2022

Conversation

cstuncsik
Copy link
Contributor

  • feat(core): adding a type package to n8n

  • feat(editor): adding custom schema generator

  • fix: add new types package to lock file

  • fix: remove n8n_io/types package

  • fix: adding path to generated schema

  • fix: handling nested lists in schema generation

  • fix: add date support to schema generation

  • fix: define dates in ISO format

  • fix: using test instead of it in repeated tests

  • fix(editor): JSON schema treat nested lists as object to allow mapping each level

  • fix(editor): rename JSON schema type

  • fix(editor): make JSON schema path required

  • fix(editor): using JSON schema bracket notation for object props to handle exceptional keys

  • fix(editor): reorder JSON schema generator function args

* feat(core): adding a type package to n8n

* feat(editor): adding custom schema generator

* fix: add new types package to lock file

* fix: remove n8n_io/types package

* fix: adding path to generated schema

* fix: handling nested lists in schema generation

* fix: add date support to schema generation

* fix: define dates in ISO format

* fix: using test instead of it in repeated tests

* fix(editor): JSON schema treat nested lists as object to allow mapping each level

* fix(editor): rename JSON schema type

* fix(editor): make JSON schema path required

* fix(editor): using JSON schema bracket notation for object props to handle exceptional keys

* fix(editor): reorder JSON schema generator function args
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 16, 2022
MiloradFilipovic and others added 17 commits November 16, 2022 14:49
* ✨ Implemented date recogniser fuction
* ✅ Added unit tests for date recogniser
* ✔️ Fixing linting errors
* 👌 Updating test cases
* feat(core): adding a type package to n8n

* feat(editor): adding custom schema generator

* fix: add new types package to lock file

* fix: remove n8n_io/types package

* fix: adding path to generated schema

* fix: handling nested lists in schema generation

* fix: add date support to schema generation

* fix: define dates in ISO format

* fix: using test instead of it in repeated tests

* fix(editor): JSON schema treat nested lists as object to allow mapping each level

* fix(editor): rename JSON schema type

* fix(editor): make JSON schema path required

* fix(editor): using JSON schema bracket notation for object props to handle exceptional keys

* fix(editor): reorder JSON schema generator function args

* fix(editor): WIP json schema view

* fix(editor): formatting fix

* fix(editor): WIP json schema viewer

* fix(editor): fix schema generator and add deep merge

* fix(editor): WIP update json schema view components

* fix(editor): extend valid date checking

* fix(editor): WIP improving JSON schema view

* chore(editor): code formatting

* feat(editor): WIP Json schema view mapping + animations

* feat(editor): WIP update mergeDeep

* feat(editor): adding first item of json data to the end once more to get sample data from the first item

* feat(editor): adding first item of json data to the end once more to get sample data from the first item
…-view

# Conflicts:
#	packages/editor-ui/src/components/RunData.vue
#	packages/editor-ui/src/utils/htmlUtils.ts
* feat(editor): WIP JSON schema telemetry call

* feat(editor): make telemetry usable outside of Vue component context

* chore(editor): remove unused variable

* Merge branch 'feature/json-schema-view' of github.com:n8n-io/n8n into n8n-5410-add-telemetry-calls

# Conflicts:
#	packages/editor-ui/src/components/RunDataJsonSchema.vue
@cstuncsik cstuncsik marked this pull request as ready for review November 23, 2022 20:00
cstuncsik and others added 9 commits November 28, 2022 10:50
…-view

# Conflicts:
#	packages/editor-ui/src/utils/canvasUtils.ts
* refactor(editor): rename JsonSchema to Schema

* fix(editor): schema component name

* fix(editor): schema pill style

* fix(editor): schema type date as string

* fix(editor): schema styles (support long text + firefox)

* fix(editor): schema truncate text if it's too long

* fix(editor): schema types

* fix(editor): droppable styles

* fix(editor): schema component props

* fix(editor): fix draggable pill styles
…-view

# Conflicts:
#	packages/editor-ui/src/Interface.ts
…-view

# Conflicts:
#	packages/editor-ui/src/components/RunDataJson.vue
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job :)

packages/editor-ui/src/components/ParameterInputFull.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/RunData.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/mixins/externalHooks.ts Outdated Show resolved Hide resolved
@cstuncsik cstuncsik requested a review from mutdmour December 5, 2022 14:03
@cstuncsik cstuncsik merged commit 4528f34 into master Dec 6, 2022
@cstuncsik cstuncsik deleted the feature/json-schema-view branch December 6, 2022 11:50
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 6, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 6, 2022
* master:
  fix: Handle error when workflow does not exist or is inaccessible (#4831)
  feat(editor): Schema view (#4615)
  fix: Enable source-maps on WorkflowRunnerProcess in `own` mode (#4832)
  ci: Fix linting on master (no-changelog) (#4830)
  feat: Add message for readonly nodes. Improve foreign credentials handling (#4759)
  feat(KoBoToolbox Node): Add support for Media file API (#4578)
  fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) (#4825)
  refactor: Codex updates for XML and HtmlExtract Nodes (#4801)
  refactor: Reactivate workflow locking (#4770)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with n8n@0.206.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants