test(editor): Fix default-owner and credentials saving e2e specs #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
commented
Dec 1, 2022
netroy
reviewed
Dec 2, 2022
mutdmour
reviewed
Dec 2, 2022
mutdmour
previously approved these changes
Dec 7, 2022
OlegIvaniv
commented
Dec 7, 2022
| @@ -695,7 +695,7 @@ export class CredentialsHelper extends ICredentialsHelper { | |||
| `Received HTTP status code: ${errorResponseData.statusCode}`, | |||
| }; | |||
| } | |||
| } else if (error.cause.code) { | |||
| } else if (error.cause?.code) { | |||
There was a problem hiding this comment.
error.cause was added in Node 16 and it throws 500 in Node 14.
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 9, 2022
* master: fix: Use license-sdk v1.6.1 (#4872) feat(editor): Node creator actions (#4696) test(editor): Set e2e test retries (#4870) fix: Increase workflow reactivation max timeout to 1 day (#4869) fix: Stop returning `UNKNOWN ERROR` in the response if an actual error message is available (#4859) fix: Issue listing executions with Postgres (#4856) test(editor): Fix flaky e2e tests (#4779) fix: Use the same entrypoint for custom docker images as for the other images (no-changelog) (#4849) refactor: Deprecate `alwaysOpenEditWindow` for `string` (#4839) fix: Upgrade sse-channel to mitigate CVE-2019-10744 (#4835) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/views/NodeView.vue
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 9, 2022
* feature/undo-redo: ⚡ Fixing tracking new nodes after latest merge ⚡ Fixing undo for moving connections ⚡ Fixing recording when moving nodes fix: Use license-sdk v1.6.1 (#4872) feat(editor): Node creator actions (#4696) test(editor): Set e2e test retries (#4870) ⚡ Fix for not clearing redo stack on every user action fix: Increase workflow reactivation max timeout to 1 day (#4869) 👌 Implemented command comparing logic 👌 Moving undo logic for disabling nodes to `NodeView` 👌 Addressing PR comments part 1 fix: Stop returning `UNKNOWN ERROR` in the response if an actual error message is available (#4859) fix: Issue listing executions with Postgres (#4856) test(editor): Fix flaky e2e tests (#4779) fix: Use the same entrypoint for custom docker images as for the other images (no-changelog) (#4849) refactor: Deprecate `alwaysOpenEditWindow` for `string` (#4839) fix: Upgrade sse-channel to mitigate CVE-2019-10744 (#4835) # Conflicts: # cypress/e2e/7-workflow-actions.cy.ts # cypress/pages/workflow.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.