Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure parent directory exists before copying over the icons to generated static directory #4865

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 8, 2022

This fixes the issue of icons not showing up for custom nodes that use a package-name with a / in them.

Fixes #4863

…enerated static directory.

This fixes the issue of icons not showing up for custom nodes that use a package-name with a `/` in them.
@netroy netroy changed the title fix: Ensure parent directory exists before copying over the icons to generated static directory. fix: Ensure parent directory exists before copying over the icons to generated static directory Dec 8, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 8, 2022
@netroy netroy merged commit 91e9a88 into master Dec 12, 2022
@netroy netroy deleted the fix-custom-node-icons branch December 12, 2022 15:41
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 13, 2022
* master:
  docs: Add codex file to Venafi TLS Protect Cloud Trigger (#4367)
  test(editor): Fix flaky workflow tags e2e tests and store screenshots from CI runs (#4903)
  feat: Update readonly node notice when using foreign credentials (no-changelog) (#4895)
  fix(editor): Fix for wrong keycode when shift is pressed (#4898)
  fix: Ensure parent directory exists before copying over the icons to generated static directory (#4865)
  📚 Update CHANGELOG.md and main package.json to 0.207.0
  🔖 Release n8n@0.207.0
  ⬆️ Set n8n-core@0.147.0, n8n-editor-ui@0.173.0, n8n-nodes-base@0.205.0 and n8n-workflow@0.129.0 on n8n
  🔖 Release n8n-editor-ui@0.173.0
  ⬆️ Set n8n-design-system@0.47.0 and n8n-workflow@0.129.0 on n8n-editor-ui
  🔖 Release n8n-design-system@0.47.0
  🔖 Release n8n-nodes-base@0.205.0
  ⬆️ Set n8n-core@0.147.0 and n8n-workflow@0.129.0 on n8n-nodes-base
  🔖 Release n8n-node-dev@0.86.0
  ⬆️ Set n8n-core@0.147.0 and n8n-workflow@0.129.0 on n8n-node-dev
  🔖 Release n8n-core@0.147.0
  ⬆️ Set n8n-workflow@0.129.0 on n8n-core
  🔖 Release n8n-workflow@0.129.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install custom nodes
3 participants