refactor: Lint for no interpolation in regular string #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To account for expressions and to make it less expensive
ivov
commented
Dec 29, 2022
| @@ -6,6 +6,7 @@ import { completeFromList, snippetCompletion } from '@codemirror/autocomplete'; | |||
| */ | |||
| export const jsSnippets = completeFromList([ | |||
| ...snippets.filter((snippet) => snippet.label !== 'class'), | |||
| // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string | |||
There was a problem hiding this comment.
Valid CodeMirror syntax: https://codemirror.net/docs/ref/#autocomplete.snippet
n8n-assistant
bot
added
n8n team
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 29, 2022
* master: ci: Fix linting on builds (no-changelog) (#5062) refactor: Lint for no interpolation in regular string (#5060) (no-changelog) ci: Fix lint for build (no-changelog) (#5059) perf: Prevent oclif from loading ts-node and typescript (#5047) (no-changelog) fix(editor): Make node title non-editable in executions view (#5046) refactor: Lint for no unneeded backticks (#5057) (no-changelog) fix(core): Fix full manual execution for error trigger as starter of 2+ node workflow (#5055) fix(editor): Support tabbing away from inline expression editor (#5056) refactor(editor): Usage and plans page on Desktop (#5051) 📚 Update CHANGELOG.md and main package.json to 0.209.4 🔖 Release n8n@0.209.4 ⬆️ Set n8n-editor-ui@0.175.4 on n8n 🔖 Release n8n-editor-ui@0.175.4 fix(editor): Usage and plans page on Desktop (#5045) feat(editor): Switch to expression on `=` input (#5044) fix(editor): Fix trigger node type identification on add to canvas (#5043)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request: #5057 (review)
Again, wrote tests but RuleTester is unable to parse backticks: