fix(GitLab Node): Update credential test endpoint #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
Joffcom
changed the title
|
Hey @svzi, Thanks for the PR, I have just given it a test and it works well. I will get this merged shortly. |
Joffcom
approved these changes
Jan 16, 2023
|
Hey @svzi, Thanks for the PR, This has now been merged and will be part of the next release 🎉 |
|
@Joffcom Thanks a lot! 🥳 |
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 19, 2023
* master: docs: Update the contribution guidelines (no-changelog) (#5165) fix(HTTP Request Node): Bug - node requires string instead of json fix(GitLab Node): Update credential test endpoint (#5166) fix(editor): Allow special chars in node selector completion (#5196) test: Add tests for pinning data (#5157) fix(core): Fix migration (no-changelog) (#5186) fix(HTTP Request Node): Response format to text is ignored for JSON responses fix(Gmail Trigger Node): Filter by labels not working (#5173) feat(Item Lists Node): Table tranformation 📚 Update CHANGELOG.md and main package.json to 0.211.2 🔖 Release n8n@0.211.2 ⬆️ Set n8n-nodes-base@0.209.2 on n8n 🔖 Release n8n-nodes-base@0.209.2 fix(core): Restore community nodes installation (#5180) feat: (Google Sheets Trigger Node): Trigger for Google Sheets test: Add e2e tests for PRs (#5176)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/no-access-via-accesstoken-to-self-hosted-gitlab-ce-ee/21802
To sum it up:
The credentials check of the GitLab node is doing wrong, because it's checking the
/usersendpoint. But that endpoint is used for listing all users of an instance and requires theapiscope. So if the token has no scope forapithe credentials test will fail.A better approach to checking the credentials, without needing any special scope for it, is the endpoint
/personal_access_tokens/self(see https://docs.gitlab.com/ee/api/personal_access_tokens.html#using-a-request-header) which shows everything related to the currently used accessToken (e.g. the scopes and expiration date).