Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Validate numeric ids in the public API #5251

Merged
merged 1 commit into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ delete:
description: The credential ID that needs to be deleted
required: true
schema:
type: string
type: number
responses:
'200':
description: Operation successful.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ required:
type: object
properties:
id:
type: string
type: number
readOnly: true
example: '42'
example: 42
name:
type: string
example: Joe's Github Credentials
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
type: object
properties:
id:
type: string
example: '1000'
type: number
example: 1000
data:
type: object
finished:
Expand All @@ -12,10 +12,10 @@ properties:
type: string
enum: ['cli', 'error', 'integrated', 'internal', 'manual', 'retry', 'trigger', 'webhook']
retryOf:
type: string
type: number
nullable: true
retrySuccessId:
type: string
type: number
nullable: true
example: '2'
startedAt:
Expand All @@ -25,7 +25,7 @@ properties:
type: string
format: date-time
workflowId:
type: string
type: number
example: '1000'
waitTill:
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ in: path
description: The ID of the execution.
required: true
schema:
type: string
type: number
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ in: path
description: The ID of the workflow.
required: true
schema:
type: string
type: number
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
type: object
properties:
id:
type: string
example: '12'
type: number
example: 12
name:
type: string
example: Production
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ required:
- settings
properties:
id:
type: string
type: number
readOnly: true
example: '1'
example: 1
name:
type: string
example: Workflow 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ properties:
example: 3600
maxLength: 3600
errorWorkflow:
type: string
example: '10'
type: number
example: 10
description: The ID of the workflow that contains the error trigger node.
timezone:
type: string
Expand Down