refactor(editor): Fix duplicate NodeView keys when navigating between routes (no-changelog) #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… routes (no-changelog)
n8n-assistant
bot
added
n8n team
OlegIvaniv
force-pushed
the
fix-duplicate-canvas-id
branch
from
54312e2 to
0b2ecce
Compare
cstuncsik
approved these changes
Feb 1, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Feb 2, 2023
* master: (26 commits) feat(editor): Completions for extensions in expression editor (#5130) feat(core): Set custom Cache-Control headers for static assets (#5322) fix(editor): Set max width for executions list (#5302) refactor(Code Node): Remove disallowed syntax checks (#5332) fix(Linear Node): Fix pagination issue for get all issues (#5324) refactor(editor): Fix duplicate NodeView keys when navigating between routes (no-changelog) (#5325) fix(Mailchimp Trigger Node): Fix webhook recreation (#5328) fix(Schedule Trigger Node): Change scheduler behaviour for intervals days and hours (#5133) fix(core): Fix oauth2 client credentials not always working (#5327) feat(Salesforce Node): Add HasOptedOutOfEmail field to lead resource (#5235) fix: Update app screenshot in README to match latest design (no-changelog) (#5314) fix(editor): Stop unsaved changes popup display when navigating away from an untouched workflow (#5259) feat(core): Simplify pagination in declarative node design (#5161) fix(core): Fix value resolution in declarative node design (#5217) feat(YouTube Node): Switch upload operation over to streaming and resumable uploads api (#5320) fix(YouTube Node): Update description for channel id (no-changelog) (#5321) fix(core): Revert back to console logging in config (no-changelog) (#5319) fix: Add paired item to the most used nodes (#5220) feat(Write Binary File Node): Stream binary data for writes (#5306) feat(editor): Roll out schema view (#5310) ... # Conflicts: # packages/cli/BREAKING-CHANGES.md # packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue # packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorInput.vue # packages/editor-ui/src/mixins/completionManager.ts # packages/editor-ui/src/mixins/expressionManager.ts # packages/editor-ui/src/plugins/codemirror/completions/__tests__/completions.test.ts # packages/editor-ui/src/plugins/codemirror/completions/datatype.completions.ts # packages/editor-ui/src/plugins/codemirror/completions/dollar.completions.ts # packages/editor-ui/src/plugins/codemirror/completions/types.ts # packages/editor-ui/src/plugins/codemirror/completions/utils.ts # packages/workflow/src/Expression.ts # packages/workflow/src/Extensions/ArrayExtensions.ts # packages/workflow/src/Extensions/DateExtensions.ts # packages/workflow/src/Extensions/Extensions.ts # packages/workflow/src/Extensions/NumberExtensions.ts # packages/workflow/src/Extensions/ObjectExtensions.ts # packages/workflow/src/Extensions/StringExtensions.ts # packages/workflow/src/Extensions/index.ts # packages/workflow/src/index.ts # packages/workflow/test/ExpressionExtensions/ArrayExtensions.test.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5259.
This PR addresses three issues:
PLACEHOLDER_EMPTY_WORKFLOW_ID) if user chooses to discard or save changes. If the navigation is canceled(closing the modal) we should not reset the workflow id.getManagedElementto retrieve the DOM element of a node by an id. This is a more reliable way of getting the DOM element of a node and should improve the memory consumption of larger workflows.computedto exportjsPlumbInstancefrom the canvas store. This fixesMaximum call stack size exceedederror when Vue dev tools are openGithub issue / Community forum post (link here to close automatically):