refactor(core): Delete duplicate code across all commands #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
krynble
previously approved these changes
Feb 10, 2023
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Feb 10, 2023
* master: 🔖 Release n8n@0.215.0 ⬆️ Set n8n-core@0.154.0, n8n-editor-ui@0.181.0, n8n-nodes-base@0.213.0 and n8n-workflow@0.136.0 on n8n 🔖 Release n8n-editor-ui@0.181.0 ⬆️ Set n8n-design-system@0.53.0 and n8n-workflow@0.136.0 on n8n-editor-ui 🔖 Release n8n-design-system@0.53.0 🔖 Release n8n-nodes-base@0.213.0 ⬆️ Set n8n-core@0.154.0 and n8n-workflow@0.136.0 on n8n-nodes-base 🔖 Release n8n-node-dev@0.93.0 ⬆️ Set n8n-core@0.154.0 and n8n-workflow@0.136.0 on n8n-node-dev 🔖 Release n8n-core@0.154.0 ⬆️ Set n8n-workflow@0.136.0 on n8n-core 🔖 Release n8n-workflow@0.136.0 fix(core): Stop using unbound calls to `stopProcess` (no-changelog) (#5456) test(Read PDF Node): Unit tests (no-changelog) (#5453) test(Move Binary Data Node): Unit tests (no-changelog) (#5442) test: Add tests for ActiveWorkflowRunner class (#5278) feat(core): Add support for WebSockets as an alternative to Server-Sent Events (#5443) refactor(core): Delete duplicate code across all commands (#5452)
|
Got released with |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the issue that all cli commands that use the database, need to initialize nodes and credentials, to be able to make the last migration work.
We should perhaps update our migration to skip the all non-schema changing queries in tests. That could help speed up tests.