Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slack Node): Add support for manually inputting a channel name #5488

Merged
merged 4 commits into from
Feb 16, 2023
Merged

feat(Slack Node): Add support for manually inputting a channel name #5488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eae7209
Add support for selecting channel by name
Joffcom Feb 15, 2023
d7d9185
fix typo in error description
Joffcom Feb 15, 2023
55e0f9c
removed name from unsupported options
Joffcom Feb 16, 2023
6399ffa
Merge branch 'master' of github.com:n8n-io/n8n into NODE-303
Joffcom Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Slack/V2/GenericFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export async function slackApiRequest(
}'`,
{
description:
'Hint: Upgrate to the Slack plan that includes the funcionality you want to use.',
'Hint: Upgrade to a Slack plan that includes the functionality you want to use.',
},
);
} else if (response.error === 'missing_scope') {
Expand Down
6 changes: 6 additions & 0 deletions packages/nodes-base/nodes/Slack/V2/MessageDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,12 @@ export const messageFields: INodeProperties[] = [
],
placeholder: 'C0122KQ70S7E',
},
{
displayName: 'By Name',
name: 'name',
type: 'string',
placeholder: '#general',
},
{
displayName: 'By URL',
name: 'url',
Expand Down