Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable intermittently failing MFA e2e tests (no-changelog) #7106

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 5, 2023

MFA e2e tests keep intermittently failing, creating distractions

Capture 2023-09-05 at 09 36 45@2x

Followup story to fix them: https://linear.app/n8n/issue/N8N-6896

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Great PR! Please pay attention to the following items before merging:

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (54bf66d) 32.44% compared to head (0c1dd3c) 32.44%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7106      +/-   ##
==========================================
- Coverage   32.44%   32.44%   -0.01%     
==========================================
  Files        3279     3279              
  Lines      198092   198092              
  Branches    21667    21664       -3     
==========================================
- Hits        64278    64275       -3     
- Misses     132754   132757       +3     
  Partials     1060     1060              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 5, 2023
@@ -37,7 +37,7 @@ describe('Two-factor authentication', () => {
});
});

it('Should be able to login with MFA token', () => {
it.skip('Should be able to login with MFA token', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try to fix them instead of disabling?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description has the followup story for Ricardo, already discussed with him.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RicardoE105 please follow up on this asap

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #2184 ↗︎

0 238 3 0 Flakiness 0

Details:

🌳 disable-intermittently-failing-mfa-e2e-tests 🖥️ browsers:node18.12.0-chrome1...
Project: n8n Commit: 0c1dd3ca75
Status: Passed Duration: 07:20 💡
Started: Sep 15, 2023 9:24 AM Ended: Sep 15, 2023 9:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit bb215bd into master Sep 15, 2023
@ivov ivov deleted the disable-intermittently-failing-mfa-e2e-tests branch September 15, 2023 09:33
MiloradFilipovic added a commit that referenced this pull request Sep 15, 2023
* master:
  feat(editor): Add Workflow history route and base page (no-changelog) (#7161)
  feat(Microsoft Outlook Node): Node overhaul (#4449)
  ci: Disable intermittently failing MFA e2e tests (no-changelog) (#7106)
  fix(editor): No need to add click emitting click events, VUE delegates the handler to the root element of the component (#7182)
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants