-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Disable intermittently failing MFA e2e tests (no-changelog) #7106
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7106 +/- ##
==========================================
- Coverage 32.44% 32.44% -0.01%
==========================================
Files 3279 3279
Lines 198092 198092
Branches 21667 21664 -3
==========================================
- Hits 64278 64275 -3
- Misses 132754 132757 +3
Partials 1060 1060 ☔ View full report in Codecov by Sentry. |
@@ -37,7 +37,7 @@ describe('Two-factor authentication', () => { | |||
}); | |||
}); | |||
|
|||
it('Should be able to login with MFA token', () => { | |||
it.skip('Should be able to login with MFA token', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try to fix them instead of disabling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description has the followup story for Ricardo, already discussed with him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RicardoE105 please follow up on this asap
Passing run #2184 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
* master: feat(editor): Add Workflow history route and base page (no-changelog) (#7161) feat(Microsoft Outlook Node): Node overhaul (#4449) ci: Disable intermittently failing MFA e2e tests (no-changelog) (#7106) fix(editor): No need to add click emitting click events, VUE delegates the handler to the root element of the component (#7182)
Got released with |
MFA e2e tests keep intermittently failing, creating distractions
Followup story to fix them: https://linear.app/n8n/issue/N8N-6896