Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add onboarding flow #7212

Merged
merged 27 commits into from
Sep 25, 2023
Merged

feat: Add onboarding flow #7212

merged 27 commits into from
Sep 25, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@mutdmour mutdmour requested a review from a team as a code owner September 19, 2023 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/cli/src/databases/migrations/**:

  • Requested review from at least two engineers on migration.
  • Avoided irreversible data migrations.
  • Avoided deleting or updating data keys.
  • Wrote 'down' migration if possible.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/mixins/**:

  • Avoided adding new mixins (use composables instead). Only removed code from here.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 80.46% and project coverage change: +0.03% 🎉

Comparison is base (dcc9cc1) 32.83% compared to head (3276a67) 32.87%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7212      +/-   ##
==========================================
+ Coverage   32.83%   32.87%   +0.03%     
==========================================
  Files        3353     3354       +1     
  Lines      199978   200088     +110     
  Branches    21923    21920       -3     
==========================================
+ Hits        65666    65774     +108     
- Misses     133200   133202       +2     
  Partials     1112     1112
Files Changed Coverage Δ
packages/cli/src/requests.ts 100.00% <ø> (ø)
packages/editor-ui/src/mixins/workflowHelpers.ts 13.30% <ø> (+0.02%) ⬆️
packages/editor-ui/src/views/NodeView.vue 16.89% <0.00%> (-0.01%) ⬇️
packages/workflow/src/Interfaces.ts 57.14% <ø> (ø)
packages/editor-ui/src/stores/templates.store.ts 17.32% <25.00%> (+0.36%) ⬆️
...kages/cli/src/databases/entities/WorkflowEntity.ts 80.95% <50.00%> (-4.05%) ⬇️
packages/editor-ui/src/router.ts 88.92% <90.47%> (+0.24%) ⬆️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)
packages/editor-ui/src/constants.ts 99.66% <100.00%> (+<0.01%) ⬆️
packages/editor-ui/src/stores/workflows.store.ts 26.39% <100.00%> (+0.72%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 19, 2023
@cypress
Copy link

cypress bot commented Sep 21, 2023 •
edited
Loading

Passing run #2264 ↗︎

0 242 3 0 Flakiness 0

Details:

🌳 ado-1104 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: 3276a679b6
Status: Passed Duration: 08:28 💡
Started: Sep 25, 2023 1:36 PM Ended: Sep 25, 2023 1:45 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

RicardoE105
RicardoE105 previously approved these changes Sep 22, 2023
View reviewed changes
packages/cli/src/databases/entities/WorkflowEntity.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour requested a review from netroy September 25, 2023 13:45
@mutdmour mutdmour merged commit 01e9340 into master Sep 25, 2023
21 checks passed
@mutdmour mutdmour deleted the ado-1104 branch September 25, 2023 13:49
This was referenced Sep 27, 2023
Closed
Merged
netroy added a commit that referenced this pull request Sep 28, 2023
@github-actions @netroy
🚀 Release 1.9.0 (#7288)
167124c 
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0)
(2023-09-28)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([2af967c](2af967c))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282](#7282))
([a80abad](a80abad))
* **core:** Fix binary data manager check on pruning
([#7251](#7251))
([484035e](484035e))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244](#7244))
([33991e9](33991e9))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([67b985f](67b985f))
* **core:** Make DNS resolution order configurable
([#7272](#7272))
([5b3121c](5b3121c))
* **core:** Make senderId required for all command messages
([#7252](#7252))
([4b01428](4b01428))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261](#7261))
([861cac5](861cac5))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948](#6948))
([0132514](0132514)),
closes [#2178](#2178)
[#2810](#2810)
[#3855](#3855)
[#2813](#2813)
* **editor:** Add debug feature docs link
([#7240](#7240))
([4614e1e](4614e1e))
* **editor:** Fix SQL editor issue
([#7236](#7236))
([647fc6c](647fc6c))
* **editor:** Ensure new Set node is on top of search list
([#7215](#7215))
([2491ccf](2491ccf))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](#7188)
([303bc8e](303bc8e))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293](#7293))
([0bc33b1](0bc33b1))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286](#7286))
([cde23a1](cde23a1))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294](#7294))
([8bc369d](8bc369d))


### Features

* Add onboarding flow
([#7212](#7212))
([01e9340](01e9340))
* **core:** Add secrets provider reload and refactor
([#7277](#7277))
([53a7502](53a7502))
* **core:** Add Tournament as the new default expression evaluator
([#6964](#6964))
([bf74f09](bf74f09))
* **core:** Initial workflow history API
([#7234](#7234))
([0083a9e](0083a9e))
* **core:** Introduce object store service
([#7225](#7225))
([fa84545](fa84545))
* **editor:** Add user cloud ID to telemetry
[#7232](#7232)
([60c152d](60c152d))
* **editor:** Rework banners framework and add email confirmation banner
([#7205](#7205))
([b0e98b5](b0e98b5))
* **MISP Node:** Update credential to support HTTP Request node
([#7268](#7268))
([e4c302c](e4c302c))


### Performance Improvements

* **core:** Skip unneeded calls on every pruning cycle
([#7260](#7260))
([db01164](db01164))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 28, 2023

Got released with n8n@1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicardoE105 RicardoE105 RicardoE105 approved these changes

@netroy netroy Awaiting requested review from netroy

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mutdmour @janober @netroy @RicardoE105