Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APITemplate.io Node): Fix action description for create pdf (no-changelog) #7226

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Sep 21, 2023

Github issue / Community forum post (link here to close automatically): #7224

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 21, 2023
@cypress
Copy link

cypress bot commented Sep 21, 2023

Passing run #2231 ↗︎

0 235 3 0 Flakiness 0

Details:

🌳 gh-7224 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: c70a4eb260
Status: Passed Duration: 08:21 💡
Started: Sep 21, 2023 10:45 AM Ended: Sep 21, 2023 10:53 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (b0e98b5) 32.81% compared to head (c70a4eb) 32.81%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7226      +/-   ##
==========================================
- Coverage   32.81%   32.81%   -0.01%     
==========================================
  Files        3348     3348              
  Lines      199868   199868              
  Branches    21911    21908       -3     
==========================================
- Hits        65588    65580       -8     
- Misses     133175   133183       +8     
  Partials     1105     1105              
Files Changed Coverage Δ
...des-base/nodes/ApiTemplateIo/ApiTemplateIo.node.ts 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joffcom Joffcom merged commit c0df5cd into master Sep 22, 2023
18 checks passed
@Joffcom Joffcom deleted the gh-7224 branch September 22, 2023 06:27
netroy pushed a commit that referenced this pull request Sep 25, 2023
…hangelog) (#7226)

Github issue / Community forum post (link here to close automatically):
#7224
@janober
Copy link
Member

janober commented Sep 25, 2023

Got released with n8n@1.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants