Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update alias for iCalendar node #7269

Merged
merged 1 commit into from
Sep 27, 2023
Merged

docs: Update alias for iCalendar node #7269

merged 1 commit into from
Sep 27, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Sep 27, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@Joffcom Joffcom changed the title docs: update alias for iCalendar node Docs: update alias for iCalendar node Sep 27, 2023
@Joffcom Joffcom changed the title Docs: update alias for iCalendar node docs: Update alias for iCalendar node Sep 27, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (db01164) 32.96% compared to head (e76b5c6) 32.98%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7269      +/-   ##
==========================================
+ Coverage   32.96%   32.98%   +0.01%     
==========================================
  Files        3355     3358       +3     
  Lines      200140   200227      +87     
  Branches    21959    21970      +11     
==========================================
+ Hits        65973    66039      +66     
- Misses     133059   133079      +20     
- Partials     1108     1109       +1     
Files Coverage Δ
packages/core/src/ObjectStore/errors.ts 100.00% <100.00%> (ø)
.../nodes-base/nodes/PagerDuty/IncidentDescription.ts 0.00% <ø> (ø)
packages/core/src/ObjectStore/utils.ts 85.71% <85.71%> (ø)
packages/core/src/index.ts 0.00% <0.00%> (ø)
packages/core/src/BinaryData/BinaryData.service.ts 39.81% <75.00%> (-0.90%) ⬇️
packages/core/src/BinaryData/utils.ts 76.92% <66.66%> (-10.58%) ⬇️
packages/core/src/NodeExecuteFunctions.ts 20.45% <0.00%> (ø)
...src/databases/repositories/execution.repository.ts 44.86% <0.00%> (-0.25%) ⬇️
packages/core/src/BinaryData/FileSystem.manager.ts 50.64% <18.18%> (ø)
...ges/core/src/ObjectStore/ObjectStore.service.ee.ts 85.13% <85.13%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 27, 2023

Passing run #2281 ↗︎

0 242 3 0 Flakiness 0

Details:

🌳 ical-alias-update 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: e76b5c69d7
Status: Passed Duration: 08:14 💡
Started: Sep 27, 2023 8:38 AM Ended: Sep 27, 2023 8:46 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit cd6e228 into master Sep 27, 2023
19 of 20 checks passed
@Joffcom Joffcom deleted the ical-alias-update branch September 27, 2023 08:49
@janober
Copy link
Member

janober commented Sep 28, 2023

Got released with n8n@1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants