Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add project and project relations entities #8421

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented Jan 23, 2024

Summary

Adds the entities, repositories, and migrations for setting up Projects.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@valya valya requested a review from a team as a code owner January 23, 2024 13:54
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 23, 2024
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 23, 2024

2 flaky tests on run #3892 ↗︎

0 338 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project: n8n Commit: 4632524d9f
Status: Passed Duration: 03:33 💡
Started: Jan 24, 2024 5:37 PM Ended: Jan 24, 2024 5:40 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8421 ↗︎

@netroy netroy force-pushed the pay-1244-create-project-db-model branch from 09f6c51 to 4632524 Compare January 24, 2024 17:30
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit c85bdc4 into feature/rbac Jan 24, 2024
32 checks passed
@netroy netroy deleted the pay-1244-create-project-db-model branch January 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants