feat(core): Link all shared workflows to the personal project of the user it's shared with #8584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Base automatically changed from
pay-1247-update-credentials-crud-apis
to
feature/rbac
February 8, 2024 13:31
…tials.projectId` not nullable
despairblue
force-pushed
the
pay-1352-make-sure-that-sharedworkflows-always-link-to-a-project
branch
from
7fa8bc2 to
d10b08c
Compare
valya
approved these changes
Feb 8, 2024
|
|
3 failed and 1 flaky tests on run #4055 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8584 ↗︎
krynble
approved these changes
Feb 8, 2024
|
|
|
The e2e test failing are also failing on feature/rbac. So I'm merging this. We can investigate the tests and fix them in another PR. |
despairblue
deleted the
pay-1352-make-sure-that-sharedworkflows-always-link-to-a-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the migration to make sure the new
projectIdfields are not nullable.That's possible because additionally to the shared credentials (#8564) this PR makes sure that all shared workflows are linked to a project.
Related tickets and issues
https://linear.app/n8n/issue/PAY-1352/make-sure-that-sharedworkflows-always-link-to-a-project
Review / Merge checklist
(no-changelog)otherwise. (conventions)