Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HTTP Request Node): Option to provide SSL Certificates in Http Request Node #9125

Merged
merged 20 commits into from
Apr 24, 2024
Merged

feat(HTTP Request Node): Option to provide SSL Certificates in Http Request Node #9125

merged 20 commits into from
Apr 24, 2024

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Apr 11, 2024 •
edited
Loading

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Apr 11, 2024
@michael-radency michael-radency changed the title feat(HTTP Request Node): New credential option for Http Request - SSL Certificate Auth feat(HTTP Request Node): Option to provide SSL Certificates in Http Request Node Apr 15, 2024
@michael-radency michael-radency requested a review from netroy April 16, 2024 06:31
netroy
netroy previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides one comment, LGTM

packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts Outdated Show resolved Hide resolved
netroy
netroy previously approved these changes Apr 18, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Apr 18, 2024 •
edited
Loading

1 flaky test on run #4768 ↗︎

0 358 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: b192fdccf4
Status: Passed Duration: 04:02 💡
Started: Apr 24, 2024 1:44 PM Ended: Apr 24, 2024 1:48 PM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9125 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency requested a review from netroy April 24, 2024 12:53
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 306b68d into master Apr 24, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1153-http-node-add-client-certificate-support branch April 24, 2024 14:28
despairblue pushed a commit that referenced this pull request Apr 26, 2024
@michael-radency @netroy @despairblue
feat(HTTP Request Node): Option to provide SSL Certificates in Http R…
752b220 
…equest Node (#9125)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
@github-actions github-actions bot mentioned this pull request May 2, 2024
Merged
@janober
Copy link
Member

janober commented May 2, 2024

Got released with n8n@1.40.0

@vbarrier
Copy link
Contributor

Hi how to use it? I try on 1.40.0 & 1.41.0 I don't see this option (and SSL Certificate credentials either)

(on a fresh new n8n setup)

@michael-radency
Copy link
Contributor Author

Hello @vbarrier, you need to enable SSL Certificates in node's settings(cog icon), after that selector would be available in node's parameters

@vbarrier
Copy link
Contributor

vbarrier commented May 12, 2024 •
edited
Loading

Thank you! But now I'm still missing the credentials part.

credentials-ssl-https

No options in Credentials settings to create one (in the node or in the credentials list)

@vbarrier
Copy link
Contributor

Thank you! But now I'm still missing the credentials part.

credentials-ssl-https No options in Credentials settings to create one (in the node or in the credentials list)

Any insight @michael-radency?

@vbarrier
Copy link
Contributor

I don't know if there is some cache on credentials list but it finally appears.

@muneebmercans
Copy link

I have a pfx certificate, in which field should I add it?
Also the value is of string type, so should it be a path to the certificate or the content of certificate?

Screen Shot 2024-05-22 at 1 52 06 PM

@netroy
Copy link
Member

netroy commented May 22, 2024

I have a pfx certificate, in which field should I add it?

Answered here

@n8n-io n8n-io locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michael-radency @janober @vbarrier @muneebmercans @netroy