feat(editor): Add initial code for NodeView and Canvas rewrite (no-changelog) #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
alexgrozav
changed the title
mutdmour
reviewed
May 10, 2024
| }); | ||
| </script> | ||
|
|
||
| <template> |
There was a problem hiding this comment.
Can you please add unit tests to all these new components? Would be great to have that
OlegIvaniv
previously approved these changes
May 23, 2024
|
|
||
| const $style = useCssModule(); | ||
|
|
||
| const emit = defineEmits(['update:modelValue', 'update:node:position', 'create:connection']); |
There was a problem hiding this comment.
It would be nice to add expected types here
| :max-zoom="2" | ||
| data-test-id="canvas" | ||
| @node-drag-stop="onNodeDragStop" | ||
| @connect="onConnect" |
There was a problem hiding this comment.
Do you know why this emit is not typed here? Looking into the VueFlow it seems like it should 🤔
There was a problem hiding this comment.
No idea. The event works though. 😅
packages/editor-ui/src/components/canvas/elements/nodes/CanvasNode.vue
Outdated
Show resolved
Hide resolved
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #5106 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9135 ↗︎
OlegIvaniv
approved these changes
May 23, 2024
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 24, 2024
* master: refactor(core): Use consistent CSRF state validation across oAuth controllers (#9104) feat(core): Print the name of the migration that cannot be reverted when using `n8n db:revert` (#9473) fix(editor): Hard load after logout to reset stores (no-changelog) (#9500) refactor(core): Stop reporting `EAUTH` error codes to Sentry (no-changelog) (#9496) fix(core): Upgrade sheetjs to address CVE-2024-22363 (#9498) refactor: Remove skipped tests (no-changelog) (#9497) feat(editor): Add initial code for NodeView and Canvas rewrite (no-changelog) (#9135) fix(editor): Show input panel with not connected message (#9495) fix(editor): Prevent XSS in node-issues tooltip (#9490) # Conflicts: # pnpm-lock.yaml
|
Got released with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the initial code for the NodeView and Canvas rewrite. We're going through a big migration to VueFlow which should take our editor experience to the next level.
features.NodeViewV2key with atruevalue tolocalStorage/workflow-v2/:idfor any workflowNodeView.v2.vuecontaining basic covered functionalityCanvas.vuecomponent and sub-components for nodes, edges, handles, buttonsCurrent supported features:
We're merging this to facilitate n8n team contributions and progressive reviewing of the added code.
Related tickets and issues
https://linear.app/n8n/project/nodeview-v2-58fb8eb1701b/issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)