Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Chromatic setup (no-changelog) #9344

Merged
merged 1 commit into from
Jun 3, 2024
Merged

ci: Update Chromatic setup (no-changelog) #9344

merged 1 commit into from
Jun 3, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented May 8, 2024 •
edited
Loading

This PR changes the Chromatic workflow to only run when

  1. there are changes in the design-system package
  2. the PR is approved
  3. the PR isn't labelled as community (because CHROMATIC_PROJECT_TOKEN secret won't be available in CI for these PRs)

Review / Merge checklist

  • PR title and summary are descriptive.

@netroy netroy force-pushed the test-chromatic-ci branch from 9d7729c to e5ed5a0 Compare May 8, 2024 12:58
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

⚠️ Visual regressions found: 141

@netroy netroy force-pushed the test-chromatic-ci branch from e5ed5a0 to fd56142 Compare June 3, 2024 09:26
netroy

This comment was marked as outdated.

Sign in to view

netroy

This comment was marked as outdated.

Sign in to view

netroy

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ No visual regressions found.

@netroy netroy force-pushed the test-chromatic-ci branch from a66efb0 to c727803 Compare June 3, 2024 09:36
@netroy netroy changed the title testing chromatic CI ci: Update Chromatic setup (no-changelog) Jun 3, 2024
@netroy netroy marked this pull request as ready for review June 3, 2024 09:39
@cypress Cypress
Copy link

cypress bot commented Jun 3, 2024

1 flaky test on run #5267 ↗︎

0 355 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: c727803336
Status: Passed Duration: 04:40 💡
Started: Jun 3, 2024 10:29 AM Ended: Jun 3, 2024 10:34 AM
Flakiness  cypress/e2e/30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Executions Test Replay Screenshots Video

Review all test suite changes for PR #9344 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 05dba62 into master Jun 3, 2024
30 checks passed
@netroy netroy deleted the test-chromatic-ci branch June 3, 2024 10:39
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @alexgrozav