Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Test variance for nodes-base benchmarks (do not merge) #9372

Closed

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 13, 2024

No description provided.

Copy link

codspeed-hq bot commented May 13, 2024

CodSpeed Performance Report

Merging #9372 will degrade performances by 97.75%

Comparing test-variance-for-nodes-base-benchmarks (5311adc) with benchmark-nodes-base-v2 (4ccef05)

Summary

⚡ 10 improvements
❌ 8 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark benchmark-nodes-base-v2 test-variance-for-nodes-base-benchmarks Change
nodes/Discord/test/v2/node/channel/getAll.workflow 61.3 ms 43.3 ms +41.53%
nodes/Discord/test/v2/node/member/roleAdd.workflow 43.7 ms 74.4 ms -41.24%
nodes/Discord/test/v2/node/member/roleRemove.workflow 72 ms 43.8 ms +64.38%
nodes/Discord/test/v2/node/message/react.workflow 56.5 ms 43.7 ms +29.23%
nodes/Files/test/convert_extract.workflow 30.7 ms 60.9 ms -49.49%
nodes/Google/BigQuery/test/v2/node/insert.autoMapMode.workflow 42.7 ms 61.5 ms -30.58%
nodes/Microsoft/Excel/test/v2/node/table/getRows.workflow 11.7 ms 32.5 ms -63.82%
nodes/Microsoft/Excel/test/v2/node/workbook/addWorksheet.workflow 18.6 ms 9.7 ms +91.51%
nodes/Microsoft/Outlook/test/v2/node/calendar/update.workflow 536.4 ms 114.9 ms ×4.7
nodes/Microsoft/Outlook/test/v2/node/draft/send.workflow 105 ms 117.1 ms -10.3%
nodes/Microsoft/Outlook/test/v2/node/message/move.workflow 118.2 ms 105.8 ms +11.77%
nodes/Microsoft/Teams/test/v2/node/task/update.workflow 5.5 ms 18.9 ms -70.74%
nodes/MoveBinaryData/test/MoveBinaryData.workflow 7.1 ms 316.2 ms -97.75%
nodes/ReadBinaryFiles/test/ReadBinaryFiles.workflow 18 ms 4.3 ms ×4.2
nodes/Switch/V1/test/switch.expression.workflow 46.2 ms 20.5 ms ×2.3
nodes/Switch/V2/test/switch.expression.workflow 71.2 ms 53.5 ms +32.99%
nodes/Switch/V3/test/switch.expression.workflow 73 ms 53.5 ms +36.47%
nodes/Wait/test/Wait.workflow 21.8 ms 44.7 ms -51.3%

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels May 13, 2024
@ivov ivov closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant