Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Overhaul input selector in NDV #9520

Merged
merged 12 commits into from
May 31, 2024
Merged

feat(editor): Overhaul input selector in NDV #9520

merged 12 commits into from
May 31, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented May 27, 2024 •
edited
Loading

Summary

  • Move input selector
  • Add node icon
  • Overhaul styling
  • Fix duplicate search inputs
image

Related tickets and issues

https://linear.app/n8n/issue/NODE-1355/overhaul-input-node-selector

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 27, 2024
@cypress Cypress
Copy link

cypress bot commented May 30, 2024 •
edited
Loading

1 flaky test on run #5235 ↗︎

0 361 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 17433f0380
Status: Passed Duration: 04:49 💡
Started: May 31, 2024 3:53 PM Ended: May 31, 2024 3:58 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video

Review all test suite changes for PR #9520 ↗︎

@elsmr elsmr requested a review from OlegIvaniv May 30, 2024 14:18
OlegIvaniv
OlegIvaniv reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezgif-4-79a0fb6f75
Works as expected & looks great! Let's just get rid of that one rogue console.log and should be good to go

packages/editor-ui/src/components/InputPanel.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/RunData.vue Outdated Show resolved Hide resolved
@elsmr elsmr requested a review from OlegIvaniv May 31, 2024 15:45
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit c0ec990 into master May 31, 2024
28 checks passed
@elsmr elsmr deleted the node-1355-overhaul-input-node-selector branch May 31, 2024 16:04
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @janober @OlegIvaniv