feat: Do not show errors not processed by n8n (no-changelog) #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Instead of completely overwriting the original error message, we should wrap the error (passing the original error as a cause in the outer error), and put the original error either behind a collapsed section on the frontend, or not render it at all. But, we should at all cost avoid modifying error.message or any other error properties.
| @@ -15,6 +17,9 @@ export class NodeOperationError extends NodeError { | |||
| ) { | |||
| if (typeof error === 'string') { | |||
| error = new Error(error); | |||
| } else if (!(error instanceof ApplicationError)) { | |||
| // this error was no processed by n8n, obfuscate error message | |||
| error.message = OBFUSCATED_ERROR_MESSAGE; | |||
There was a problem hiding this comment.
We should stop overwriting error properties like this, as that remove context on errors that get reported to Sentry.
n8n-assistant
bot
added
core
…tidy-up-internal-node-errors
…tidy-up-internal-node-errors
…tidy-up-internal-node-errors
…nternal-node-errors
netroy
approved these changes
Jun 19, 2024
3 flaky tests on run #5593 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9598 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…9598) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…9598) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there is an unhanded exception in n8n's execution code, we currently display the inner workings of n8n too prominently
Related tickets and issues
https://linear.app/n8n/issue/NODE-1338/tidy-up-internal-node-errors