Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use turbo for build cache (no-changelog) #9696

Merged
merged 1 commit into from
Jul 5, 2024
Merged

ci: Use turbo for build cache (no-changelog) #9696

merged 1 commit into from
Jul 5, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 11, 2024 •
edited
Loading

This PR setups a remote cache for turbo-repo using a local server that backs up the cache using Github Actions Cache service.
Once this is working, build, test, and lint tasks should significantly speed up.

Related tickets and issues

https://linear.app/n8n/issue/N8N-4262

Review / Merge checklist

  • PR title and summary are descriptive

@ivov
Copy link
Contributor

ivov commented Jun 11, 2024

Last attempt: #7805

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 11, 2024
@netroy netroy force-pushed the setup-turborepo-cache branch from 9480a36 to 5e94e0a Compare June 11, 2024 15:48
@netroy netroy marked this pull request as ready for review June 11, 2024 16:43
@netroy netroy requested a review from ivov June 11, 2024 16:43
@despairblue
Copy link
Contributor

I don't see a significant difference between the reruns here: https://github.com/n8n-io/n8n/actions/runs/9468790143
Attempt 2 and 3 should be faster right? Or do we only write to the cache on master and read in PRs?

@netroy
Copy link
Member Author

netroy commented Jun 13, 2024

I don't see a significant difference between the reruns

dtinth/setup-github-actions-caching-for-turbo#26

@netroy netroy marked this pull request as draft June 13, 2024 11:09
@netroy netroy mentioned this pull request Jun 13, 2024
Merged
2 tasks
@netroy netroy force-pushed the setup-turborepo-cache branch 2 times, most recently from 58952b3 to 6b8de45 Compare June 24, 2024 08:04
@netroy netroy force-pushed the setup-turborepo-cache branch 3 times, most recently from 00a4fea to 0bc41c1 Compare July 3, 2024 12:44
@netroy netroy marked this pull request as ready for review July 3, 2024 13:08
@netroy
Copy link
Member Author

netroy commented Jul 3, 2024

I had some troubles setting up the typecheck target via turborepo, so this PR is now based on top of #9925

@netroy netroy force-pushed the setup-turborepo-cache branch from 0bc41c1 to adc650e Compare July 3, 2024 16:28
despairblue
despairblue previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow changes look good. I don't know anything about the config format, but it looks reasonable and I tried it locally and it works.

.github/workflows/ci-postgres-mysql.yml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jul 4, 2024 •
edited
Loading

4 flaky tests on run #5808 ↗︎

0 399 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2b05991d43
Status: Passed Duration: 05:09 💡
Started: Jul 5, 2024 3:26 PM Ended: Jul 5, 2024 3:32 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9696 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy mentioned this pull request Jul 5, 2024
Merged
1 task
@netroy netroy force-pushed the setup-turborepo-cache branch from adc650e to 2b05991 Compare July 5, 2024 14:53
@netroy netroy requested a review from despairblue July 5, 2024 14:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit b910ed6 into master Jul 5, 2024
33 checks passed
@netroy netroy deleted the setup-turborepo-cache branch July 5, 2024 15:43
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
@netroy @jeanpaul
ci: Use turbo for build cache (no-changelog) (#9696)
507ee7c
@netroy netroy mentioned this pull request Aug 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

@despairblue despairblue Awaiting requested review from despairblue

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netroy @ivov @despairblue @janober