Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove inferral of execution status (no-changelog) #9829

Merged
merged 1 commit into from
Jun 21, 2024
Merged

refactor(core): Remove inferral of execution status (no-changelog) #9829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/cli/src/executions/execution.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type {
ExecutionStatus,
} from 'n8n-workflow';
import {
ErrorReporterProxy as EventReporter,
ApplicationError,
ExecutionStatusList,
Workflow,
Expand All @@ -27,7 +26,6 @@ import { NodeTypes } from '@/NodeTypes';
import { Queue } from '@/Queue';
import type { ExecutionRequest, ExecutionSummaries } from './execution.types';
import { WorkflowRunner } from '@/WorkflowRunner';
import { getStatusUsingPreviousExecutionStatusMethod } from './executionHelpers';
import type { IGetExecutionsQueryFilter } from '@db/repositories/execution.repository';
import { ExecutionRepository } from '@db/repositories/execution.repository';
import { WorkflowRepository } from '@db/repositories/workflow.repository';
Expand Down Expand Up @@ -111,12 +109,6 @@ export class ExecutionService {
return undefined;
}

if (!execution.status) {
const { data, workflowData, ...rest } = execution;
EventReporter.info('Detected `null` execution status', { extra: { execution: rest } });
execution.status = getStatusUsingPreviousExecutionStatusMethod(execution);
}

return execution;
}

Expand Down
18 changes: 0 additions & 18 deletions packages/cli/src/executions/executionHelpers.ts
View file
Open in desktop

This file was deleted.

Loading