N8N-3776-expressions-xss-part-2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
reviewed
Jun 2, 2022
src/tmpl.js
Outdated
Comment on lines
155
to
156
| // var exposedVars = ['Date'] | ||
| // expr = 'var window = { ' + exposedVars.map(function(varName) { return varName + ': ' + (typeof window !== 'object' ? 'global' : 'window') + '.' + varName }).join(', ') + ' }; ' + expr |
There was a problem hiding this comment.
Leftover comments to remove or do they need to be preserved?
There was a problem hiding this comment.
Good catch! Forgot about it.
ivov
reviewed
Jun 2, 2022
| expect(render('{ this.$a }')).to.be(5) | ||
| expect(render('{ void 0 }')).to.be(undefined) | ||
| // without unprefixed global/window, default convertion to `new (D).Date()` throws here | ||
| data.Date = typeof window !== 'object' ? 'global' : 'window' | ||
| expect(render('{ new ' + data.Date + '.Date() }')).to.be.a('object') | ||
| data.Date = Date |
There was a problem hiding this comment.
Comment on L216 is outdated now? If so we should remove it.
There was a problem hiding this comment.
It is outdated. Removed!
ivov
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added window/global variable overwrite in eval context.
We will need to whitelist global variables/constructors that we want to expose in the application using
data.