Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

fix xcode 10.2 issue #54

Merged
merged 2 commits into from
Apr 14, 2019
Merged

fix xcode 10.2 issue #54

merged 2 commits into from
Apr 14, 2019

Conversation

OPADA-Eng
Copy link
Contributor

Fix issue #53

@tralves
Copy link

tralves commented Mar 26, 2019

Thanks @OPADA-Eng! I ran into this issue today!
(turns out my project isn't using this plugin after all, but if it were, you had saved my life)

@FranciZ
Copy link

FranciZ commented Mar 27, 2019

@OPADA-Eng the fix doesn't work for me. The init function is undefined if updating version to 13. I guess it was deprecated. The version that worked for me is 12.1.3.

@OPADA-Eng
Copy link
Contributor Author

@FranciZ Thanks For providing us with this information.
I made the PR refer to the version you mentioned.

@OPADA-Eng
Copy link
Contributor Author

@naderio Can you please merge this pull request

@naderio
Copy link
Owner

naderio commented Apr 8, 2019

@OPADA-Eng apologies for not checking this, I've not received a notification until your mention.
I'll review and merge if all good

@OPADA-Eng
Copy link
Contributor Author

@naderio No problem, Thanks in advance.

@naderio
Copy link
Owner

naderio commented Apr 8, 2019

@OPADA-Eng are you sure that your change do not break anything? last time iOS dependency upgrade were attempted, it broke the code

@OPADA-Eng
Copy link
Contributor Author

OPADA-Eng commented Apr 8, 2019 via email

@OPADA-Eng
Copy link
Contributor Author

@naderio Any news with this?

@mastashake08
Copy link

PLEASE MERGE THIS

@naderio naderio merged commit 9c518db into naderio:master Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants