add support for inline style css functions #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spassarop - Can you look into this PR and determine if it's a safe and appropriate change? |
|
At a minimum, I think some rainy day tests for the added functionality are
in order. Unfortunately, I don't have enough CSS expertise to offer any.
…On Mon, Sep 23, 2024, 1:23 PM Dave Wichers ***@***.***> wrote:
@spassarop <https://github.com/spassarop> - Can you look into this PR and
determine if it's a safe and appropriate change?
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6PG6ACOMKRWL2G2EQAXLZYBFBNAVCNFSM6AAAAABOVZ2GQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHEYDQOJXGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@spassarop Can I please get a review on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom
styleattributes are stripped from the output and not applied. We need to support inline style css functions for our use-case.adding support for the var(...) css function.
Details can be found at https://jira.atlassian.com/browse/CONFCLOUD-77050
Added tests as well