maskinporten: add validation rule for exposed scopes #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource set The `delegationSource` field for exposed scopes is optional. However, if `delegationSource` is set, the separator field must accordingly be set to `"/"` due to some arcane validation logic in Altinn (see previous PR: #214) This commit adds a CEL validation rule to the CRD schema that enforces this logic. See also: - https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-rules - https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/#optional-parameters
tronghn
force-pushed
the
maskinporten-validate-delegation
branch
from
5a1f6cd
to
4f74631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
delegationSourcefield for exposed scopes is optional. However ifdelegationSourceis set, the separator field must accordingly be set to"/"due to some arcane validation logic in Altinn (see previous PR: #214)This adds a CEL validation rule to the CRD schema that enforces this logic.
See also: