Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

add multipart support in rest client #20

Closed
neo7337 opened this issue Dec 20, 2022 · 4 comments · Fixed by #35
Closed

add multipart support in rest client #20

neo7337 opened this issue Dec 20, 2022 · 4 comments · Fixed by #35
Assignees
Labels
enhancement New feature or request

Comments

@neo7337
Copy link
Contributor

neo7337 commented Dec 20, 2022

No description provided.

@neo7337 neo7337 changed the title add multipar support in rest client add multipart support in rest client Dec 20, 2022
@nandagopalan nandagopalan added this to the Version 1.0 milestone Dec 20, 2022
@nandagopalan nandagopalan added the enhancement New feature or request label Dec 20, 2022
@nandagopalan
Copy link
Contributor

May be a Request#SetMultiPartFile(filename, params map[string]string) can be created .

@nandagopalan
Copy link
Contributor

@neo7337 Does It make sense to use vfs here ?

@neo7337
Copy link
Contributor Author

neo7337 commented Dec 21, 2022

Don't think so vfs involvement should be necessary, we are just adding the files to the request to be read by the server.
Adding the files to the request can be something like this:-

  1. read the file from the client location
  2. create a stream
  3. via reader set the file stream to the multipart object with the provided param name of the file

lemme know if I am making sense!

@nandagopalan
Copy link
Contributor

The only reason I was thinking vfs is because then it'll allow remote to remote file upload. It's going to be tricky but we can park it and support local file for the time being.

neo7337 added a commit that referenced this issue Dec 21, 2022
neo7337 added a commit that referenced this issue Dec 21, 2022
@neo7337 neo7337 linked a pull request Dec 22, 2022 that will close this issue
nandagopalan added a commit that referenced this issue Dec 24, 2022
nandagopalan added a commit that referenced this issue Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants